[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [ktexteditor] src: clang-tidy modernize-use-override
From:       Dominik Haumann <null () kde ! org>
Date:       2017-12-31 17:18:51
Message-ID: E1eVhG7-0005Vh-5q () code ! kde ! org
[Download RAW message or body]

Git commit 225d774b5219b1f891ecb3832c555dc8e8ab68e9 by Dominik Haumann.
Committed on 31/12/2017 at 17:18.
Pushed by dhaumann into branch 'master'.

clang-tidy modernize-use-override

Summary: This patch only removes the 'virtual', since the Q_DECL_OVERRIDE already \
existed.

Test Plan: make test

Reviewers: kfunk, mlaurent

Reviewed By: mlaurent

Subscribers: #frameworks

Tags: #kate, #frameworks

Differential Revision: https://phabricator.kde.org/D9571

M  +6    -6    src/completion/katekeywordcompletion.h
M  +1    -1    src/document/katedocument.h

https://commits.kde.org/ktexteditor/225d774b5219b1f891ecb3832c555dc8e8ab68e9

diff --git a/src/completion/katekeywordcompletion.h \
b/src/completion/katekeywordcompletion.h index fe068021..7ba1efc2 100644
--- a/src/completion/katekeywordcompletion.h
+++ b/src/completion/katekeywordcompletion.h
@@ -43,13 +43,13 @@ public:
     int rowCount(const QModelIndex& parent = QModelIndex()) const Q_DECL_OVERRIDE;
     QModelIndex parent(const QModelIndex& index) const Q_DECL_OVERRIDE;
     QModelIndex index(int row, int column, const QModelIndex& parent = \
                QModelIndex()) const Q_DECL_OVERRIDE;
-    virtual void completionInvoked(KTextEditor::View* view, const \
                KTextEditor::Range& range,
-                                   InvocationType invocationType) Q_DECL_OVERRIDE;
+    void completionInvoked(KTextEditor::View* view, const KTextEditor::Range& range,
+                           InvocationType invocationType) Q_DECL_OVERRIDE;
     KTextEditor::Range completionRange(KTextEditor::View* view, const \
                KTextEditor::Cursor& position) Q_DECL_OVERRIDE;
-    virtual bool shouldAbortCompletion(KTextEditor::View* view, const \
                KTextEditor::Range& range,
-                                       const QString& currentCompletion) \
                Q_DECL_OVERRIDE;
-    virtual bool shouldStartCompletion(KTextEditor::View* view, const QString& \
                insertedText, bool userInsertion,
-                                       const KTextEditor::Cursor& position) \
Q_DECL_OVERRIDE; +    bool shouldAbortCompletion(KTextEditor::View* view, const \
KTextEditor::Range& range, +                               const QString& \
currentCompletion) Q_DECL_OVERRIDE; +    bool \
shouldStartCompletion(KTextEditor::View* view, const QString& insertedText, bool \
userInsertion, +                               const KTextEditor::Cursor& position) \
                Q_DECL_OVERRIDE;
     MatchReaction matchingItem(const QModelIndex& matched) Q_DECL_OVERRIDE;
     bool shouldHideItemsWithEqualNames() const Q_DECL_OVERRIDE;
 
diff --git a/src/document/katedocument.h b/src/document/katedocument.h
index 9ef90629..7c470607 100644
--- a/src/document/katedocument.h
+++ b/src/document/katedocument.h
@@ -633,7 +633,7 @@ public:
      * @param emptyBehavior behavior on becoming empty
      * @return new moving range for the document
      */
-    virtual KTextEditor::MovingRange *newMovingRange(const KTextEditor::Range \
&range, KTextEditor::MovingRange::InsertBehaviors insertBehaviors = \
KTextEditor::MovingRange::DoNotExpand +    KTextEditor::MovingRange \
*newMovingRange(const KTextEditor::Range &range, \
KTextEditor::MovingRange::InsertBehaviors insertBehaviors = \
                KTextEditor::MovingRange::DoNotExpand
             , KTextEditor::MovingRange::EmptyBehavior emptyBehavior = \
KTextEditor::MovingRange::AllowEmpty) Q_DECL_OVERRIDE;  
     /**


[prev in list] [next in list] [prev in thread] [next in thread]