[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [elisa] src: Changes on header
From:       Matthieu Gallien <null () kde ! org>
Date:       2017-12-31 15:00:55
Message-ID: E1eVf6d-0004mh-EC () code ! kde ! org
[Download RAW message or body]

Git commit b3f5ee70c1f650f718ded25a46776bf76a00d331 by Matthieu Gallien, on=
 behalf of Diego Gangl.
Committed on 31/12/2017 at 15:00.
Pushed by mgallien into branch 'master'.

Changes on header

Summary:
This patch increases the blur in the headerbar background, increases contra=
st
between background and text, and brings the labels closer together.

(I increased the saturation a bit after talking about it in the ML)

Screen:

{F5588135}

Test Plan: Play some music :)

Reviewers: mgallien, #elisa

Reviewed By: mgallien, #elisa

Subscribers: andreask

Tags: #elisa, #vdg

Differential Revision: https://phabricator.kde.org/D9560

M  +19   -66   src/HeaderBar.qml

https://commits.kde.org/elisa/b3f5ee70c1f650f718ded25a46776bf76a00d331

diff --git a/src/HeaderBar.qml b/src/HeaderBar.qml
index 9cb59da..74836c0 100644
--- a/src/HeaderBar.qml
+++ b/src/HeaderBar.qml
@@ -66,28 +66,21 @@ FocusScope {
             opacity: 1
 =

             layer.enabled: true
-            layer.effect: Desaturate {
+            layer.effect: HueSaturation {
                 cached: true
 =

-                desaturation: -0.2
+                lightness: -0.5
+                saturation: 0.9
 =

                 layer.enabled: true
-                layer.effect: BrightnessContrast {
+                layer.effect: GaussianBlur {
                     cached: true
 =

-                    brightness: -0.2
-                    contrast: -0.1
+                    radius: 256
+                    deviation: 12
+                    samples: 129
 =

-                    layer.enabled: true
-                    layer.effect: GaussianBlur {
-                        cached: true
-
-                        radius: 32
-                        deviation: 12
-                        samples: 65
-
-                        transparentBorder: false
-                    }
+                    transparentBorder: false
                 }
             }
         }
@@ -108,28 +101,21 @@ FocusScope {
             opacity: 0
 =

             layer.enabled: true
-            layer.effect: Desaturate {
+            layer.effect: HueSaturation {
                 cached: true
 =

-                desaturation: -0.2
+                lightness: -0.5
+                saturation: 0.9
 =

                 layer.enabled: true
-                layer.effect: BrightnessContrast {
+                layer.effect: GaussianBlur {
                     cached: true
 =

-                    brightness: -0.2
-                    contrast: -0.1
-
-                    layer.enabled: true
-                    layer.effect: GaussianBlur {
-                        cached: true
-
-                        radius: 32
-                        deviation: 12
-                        samples: 65
+                    radius: 256
+                    deviation: 12
+                    samples: 129
 =

-                        transparentBorder: false
-                    }
+                    transparentBorder: false
                 }
             }
         }
@@ -209,17 +195,6 @@ FocusScope {
                     }
 =

                     fillMode: Image.PreserveAspectFit
-
-                    layer.enabled: true
-                    layer.effect: DropShadow {
-                        horizontalOffset: elisaTheme.shadowOffset
-                        verticalOffset: elisaTheme.shadowOffset
-
-                        radius: 5.0
-                        samples: 11
-
-                        color: myPalette.shadow
-                    }
                 }
 =

                 Image {
@@ -240,17 +215,6 @@ FocusScope {
                     }
 =

                     fillMode: Image.PreserveAspectFit
-
-                    layer.enabled: true
-                    layer.effect: DropShadow {
-                        horizontalOffset: elisaTheme.shadowOffset
-                        verticalOffset: elisaTheme.shadowOffset
-
-                        radius: 5.0
-                        samples: 11
-
-                        color: myPalette.shadow
-                    }
                 }
             }
 =

@@ -280,19 +244,10 @@ FocusScope {
                     Layout.alignment: Qt.AlignLeft
                     elide: Text.ElideRight
                     color: myPalette.highlightedText
-                    font.pixelSize: elisaTheme.defaultFontPixelSize * 2
+                    font.pixelSize: elisaTheme.defaultFontPixelSize * 2.5
                     font.bold: true
 =

-                    layer.effect: Glow {
-                        cached: true
-
-                        color: myPalette.shadow
-
-                        radius: 4.0
-                        samples: 9
-                    }
-
-                    Layout.bottomMargin: titleFontInfo.height
+                    Layout.bottomMargin: titleFontInfo.height * 0.5
                 }
 =

                 LabelWithToolTip {
@@ -312,8 +267,6 @@ FocusScope {
                         radius: 4.0
                         samples: 9
                     }
-
-                    Layout.bottomMargin: titleFontInfo.height
                 }
 =

                 LabelWithToolTip {
@@ -324,6 +277,7 @@ FocusScope {
                     elide: Text.ElideRight
                     color: myPalette.highlightedText
                     font.weight: Font.Light
+                    font.pixelSize: elisaTheme.defaultFontPixelSize * 1
 =

                     layer.effect: Glow {
                         cached: true
@@ -334,7 +288,6 @@ FocusScope {
                         samples: 9
                     }
 =

-                    Layout.bottomMargin: titleFontInfo.height
                 }
 =

                 RatingStar {
[prev in list] [next in list] [prev in thread] [next in thread]