[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [okular/Applications/17.12] /: Don't call m_formsMessage->setVisible( true ) on unsetDummyMode
From:       Albert Astals Cid <null () kde ! org>
Date:       2017-12-14 23:32:11
Message-ID: E1ePcz5-0007YO-Mo () code ! kde ! org
[Download RAW message or body]

Git commit 9504d91c6111e5f8c9ace8c9f059521f8c5a44ac by Albert Astals Cid.
Committed on 14/12/2017 at 23:32.
Pushed by aacid into branch 'Applications/17.12'.

Don't call m_formsMessage->setVisible( true ) on unsetDummyMode

The only reasons to show m_formsMessage are on openFile if we have forms (to show the \
toggle button) or if we have xfa forms (unsuppported warning)

M  +0    -1    part.cpp

https://commits.kde.org/okular/9504d91c6111e5f8c9ace8c9f059521f8c5a44ac

diff --git a/part.cpp b/part.cpp
index d2f179a3..8a29901c 100644
--- a/part.cpp
+++ b/part.cpp
@@ -3336,7 +3336,6 @@ void Part::unsetDummyMode()
 
     // attach the actions of the children widgets too
     m_formsMessage->addAction( m_pageView->toggleFormsAction() );
-    m_formsMessage->setVisible( m_pageView->toggleFormsAction() != nullptr );
 
     // ensure history actions are in the correct state
     updateViewActions();


[prev in list] [next in list] [prev in thread] [next in thread]