[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [pimcommon] src/pimcommon: Clean up
From:       Montel Laurent <null () kde ! org>
Date:       2017-11-30 21:55:53
Message-ID: E1eKWoD-0003pT-6Q () code ! kde ! org
[Download RAW message or body]

Git commit e4b1a563f6fed6ea699f075bed6a7392b877ae05 by Montel Laurent.
Committed on 30/11/2017 at 21:55.
Pushed by mlaurent into branch 'master'.

Clean up

M  +0    -2    src/pimcommon/autocorrection/autocorrectionwidget.cpp
M  +1    -3    src/pimcommon/autocorrection/import/importabstractautocorrection.cpp
M  +2    -2    src/pimcommon/autocorrection/import/importabstractautocorrection.h
M  +1    -2    src/pimcommon/autocorrection/widgets/lineeditwithautocorrection.cpp
M  +1    -2    src/pimcommon/autocorrection/widgets/richtexteditwithautocorrection.cpp
 M  +0    -1    src/pimcommon/configureplugins/configureplugindialog.cpp
M  +0    -1    src/pimcommon/customtools/customtoolswidgetng.cpp
M  +0    -1    src/pimcommon/genericgrantlee/genericgrantleeformatter.cpp
M  +0    -2    src/pimcommon/genericplugins/abstractgenericplugininterface.cpp
M  +1    -3    src/pimcommon/genericplugins/genericpluginmanager.cpp

https://commits.kde.org/pimcommon/e4b1a563f6fed6ea699f075bed6a7392b877ae05

diff --git a/src/pimcommon/autocorrection/autocorrectionwidget.cpp \
b/src/pimcommon/autocorrection/autocorrectionwidget.cpp index 06550b1..ecae3d1 100644
--- a/src/pimcommon/autocorrection/autocorrectionwidget.cpp
+++ b/src/pimcommon/autocorrection/autocorrectionwidget.cpp
@@ -42,8 +42,6 @@ class PimCommon::AutoCorrectionWidgetPrivate
 public:
     AutoCorrectionWidgetPrivate()
         : ui(new Ui::AutoCorrectionWidget)
-        , mAutoCorrection(nullptr)
-        , mWasChanged(false)
     {
     }
 
diff --git a/src/pimcommon/autocorrection/import/importabstractautocorrection.cpp \
b/src/pimcommon/autocorrection/import/importabstractautocorrection.cpp index \
                36972ef..4e48e1b 100644
--- a/src/pimcommon/autocorrection/import/importabstractautocorrection.cpp
+++ b/src/pimcommon/autocorrection/import/importabstractautocorrection.cpp
@@ -20,9 +20,7 @@
 using namespace PimCommon;
 
 ImportAbstractAutocorrection::ImportAbstractAutocorrection(QWidget *parent)
-    : mMaxFindStringLenght(0)
-    , mMinFindStringLenght(0)
-    , mParent(parent)
+    : mParent(parent)
 {
 }
 
diff --git a/src/pimcommon/autocorrection/import/importabstractautocorrection.h \
b/src/pimcommon/autocorrection/import/importabstractautocorrection.h index \
                1aa87fb..3bdc950 100644
--- a/src/pimcommon/autocorrection/import/importabstractautocorrection.h
+++ b/src/pimcommon/autocorrection/import/importabstractautocorrection.h
@@ -53,8 +53,8 @@ public:
     int minFindStringLenght() const;
 
 protected:
-    int mMaxFindStringLenght;
-    int mMinFindStringLenght;
+    int mMaxFindStringLenght = 0;
+    int mMinFindStringLenght = 0;
     QSet<QString> mUpperCaseExceptions;
     QSet<QString> mTwoUpperLetterExceptions;
     QHash<QString, QString> mAutocorrectEntries;
diff --git a/src/pimcommon/autocorrection/widgets/lineeditwithautocorrection.cpp \
b/src/pimcommon/autocorrection/widgets/lineeditwithautocorrection.cpp index \
                9240885..09fabc6 100644
--- a/src/pimcommon/autocorrection/widgets/lineeditwithautocorrection.cpp
+++ b/src/pimcommon/autocorrection/widgets/lineeditwithautocorrection.cpp
@@ -26,7 +26,6 @@ class PimCommon::LineEditWithAutoCorrectionPrivate
 public:
     LineEditWithAutoCorrectionPrivate()
         : mAutoCorrection(new PimCommon::AutoCorrection())
-        , mNeedToDeleteAutoCorrection(true)
     {
     }
 
@@ -38,7 +37,7 @@ public:
     }
 
     PimCommon::AutoCorrection *mAutoCorrection = nullptr;
-    bool mNeedToDeleteAutoCorrection;
+    bool mNeedToDeleteAutoCorrection = true;
 };
 
 LineEditWithAutoCorrection::LineEditWithAutoCorrection(QWidget *parent, const \
                QString &configFile)
diff --git a/src/pimcommon/autocorrection/widgets/richtexteditwithautocorrection.cpp \
b/src/pimcommon/autocorrection/widgets/richtexteditwithautocorrection.cpp index \
                7462450..5e3c388 100644
--- a/src/pimcommon/autocorrection/widgets/richtexteditwithautocorrection.cpp
+++ b/src/pimcommon/autocorrection/widgets/richtexteditwithautocorrection.cpp
@@ -27,7 +27,6 @@ class PimCommon::RichTextEditWithAutoCorrectionPrivate
 public:
     RichTextEditWithAutoCorrectionPrivate()
         : mAutoCorrection(new PimCommon::AutoCorrection())
-        , mNeedToDelete(true)
     {
     }
 
@@ -39,7 +38,7 @@ public:
     }
 
     PimCommon::AutoCorrection *mAutoCorrection = nullptr;
-    bool mNeedToDelete = false;
+    bool mNeedToDelete = true;
 };
 
 RichTextEditWithAutoCorrection::RichTextEditWithAutoCorrection(QWidget *parent)
diff --git a/src/pimcommon/configureplugins/configureplugindialog.cpp \
b/src/pimcommon/configureplugins/configureplugindialog.cpp index 6cfaea8..c41dbb9 \
                100644
--- a/src/pimcommon/configureplugins/configureplugindialog.cpp
+++ b/src/pimcommon/configureplugins/configureplugindialog.cpp
@@ -27,7 +27,6 @@ using namespace PimCommon;
 
 ConfigurePluginDialog::ConfigurePluginDialog(QWidget *parent)
     : QDialog(parent)
-    , mButtonBox(nullptr)
 {
 }
 
diff --git a/src/pimcommon/customtools/customtoolswidgetng.cpp \
b/src/pimcommon/customtools/customtoolswidgetng.cpp index 227e8c1..40c1036 100644
--- a/src/pimcommon/customtools/customtoolswidgetng.cpp
+++ b/src/pimcommon/customtools/customtoolswidgetng.cpp
@@ -31,7 +31,6 @@ class PimCommon::CustomToolsWidgetNgPrivate
 {
 public:
     CustomToolsWidgetNgPrivate()
-        : mStackedWidget(nullptr)
     {
     }
 
diff --git a/src/pimcommon/genericgrantlee/genericgrantleeformatter.cpp \
b/src/pimcommon/genericgrantlee/genericgrantleeformatter.cpp index 693bd71..b20f633 \
                100644
--- a/src/pimcommon/genericgrantlee/genericgrantleeformatter.cpp
+++ b/src/pimcommon/genericgrantlee/genericgrantleeformatter.cpp
@@ -32,7 +32,6 @@ public:
     GenericGrantleeFormatterPrivate(const QString &defaultHtmlMain, const QString \
&themePath)  : mThemePath(themePath)
         , mDefaultMainFile(defaultHtmlMain)
-        , mEngine(nullptr)
     {
         initializeEngine();
     }
diff --git a/src/pimcommon/genericplugins/abstractgenericplugininterface.cpp \
b/src/pimcommon/genericplugins/abstractgenericplugininterface.cpp index \
                162511b..7158ac0 100644
--- a/src/pimcommon/genericplugins/abstractgenericplugininterface.cpp
+++ b/src/pimcommon/genericplugins/abstractgenericplugininterface.cpp
@@ -23,8 +23,6 @@ class PimCommon::AbstractGenericPluginInterfacePrivate
 {
 public:
     AbstractGenericPluginInterfacePrivate()
-        : plugin(nullptr)
-        , parentWidget(nullptr)
     {
     }
 
diff --git a/src/pimcommon/genericplugins/genericpluginmanager.cpp \
b/src/pimcommon/genericplugins/genericpluginmanager.cpp index f065dc5..e563af3 100644
--- a/src/pimcommon/genericplugins/genericpluginmanager.cpp
+++ b/src/pimcommon/genericplugins/genericpluginmanager.cpp
@@ -30,8 +30,6 @@ class GenericPluginInfo
 {
 public:
     GenericPluginInfo()
-        : plugin(nullptr)
-        , isEnabled(true)
     {
     }
 
@@ -39,7 +37,7 @@ public:
     QString metaDataFileName;
     PimCommon::PluginUtilData pluginData;
     PimCommon::GenericPlugin *plugin = nullptr;
-    bool isEnabled;
+    bool isEnabled = true;
 };
 
 namespace {


[prev in list] [next in list] [prev in thread] [next in thread]