[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kwin] plugins/platforms/drm: [platforms/drm] Fix typo in cleanup of eglSurface
From:       Martin_Flöser <null () kde ! org>
Date:       2017-10-31 16:06:02
Message-ID: E1e9Z3C-0007aq-Qm () code ! kde ! org
[Download RAW message or body]

Git commit 7739dea33c2233b1fbbd49f52fc6263bfc2e2f0c by Martin Flöser.
Committed on 31/10/2017 at 16:05.
Pushed by graesslin into branch 'master'.

[platforms/drm] Fix typo in cleanup of eglSurface

When switching modes the wrong surface was destroyed resulting in a
crash.

M  +1    -1    plugins/platforms/drm/egl_gbm_backend.cpp

https://commits.kde.org/kwin/7739dea33c2233b1fbbd49f52fc6263bfc2e2f0c

diff --git a/plugins/platforms/drm/egl_gbm_backend.cpp b/plugins/platforms/drm/egl_gbm_backend.cpp
index 610358d07..51861f310 100644
--- a/plugins/platforms/drm/egl_gbm_backend.cpp
+++ b/plugins/platforms/drm/egl_gbm_backend.cpp
@@ -168,7 +168,7 @@ bool EglGbmBackend::resetOutput(Output &o, DrmOutput *drmOutput)
     } else {
         // destroy previous surface
         if (o.eglSurface != EGL_NO_SURFACE) {
-            eglDestroySurface(eglDisplay(), eglSurface);
+            eglDestroySurface(eglDisplay(), o.eglSurface);
         }
         o.eglSurface = eglSurface;
         o.gbmSurface = gbmSurface;
[prev in list] [next in list] [prev in thread] [next in thread]