[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [juk/frameworks] /: Port PlaylistCollection away from KInputDialog.
From:       Christoph Feck <cfeck () kde ! org>
Date:       2017-10-01 2:21:19
Message-ID: 67672827-49ab-beab-3722-471642e467c8 () kde ! org
[Download RAW message or body]

On 30.09.2017 23:33, Michael Pyne wrote:
> Git commit cf75c584d7ea43325f71364e1e8192bc48dbc754 by Michael Pyne.
> Committed on 30/09/2017 at 19:53.
> Pushed by mpyne into branch 'frameworks'.
>
> Port PlaylistCollection away from KInputDialog.
>
> M  +4    -2    playlistcollection.cpp
>
> https://commits.kde.org/juk/cf75c584d7ea43325f71364e1e8192bc48dbc754
>
> diff --git a/playlistcollection.cpp b/playlistcollection.cpp
> index 450d4f7..73ed343 100644
> --- a/playlistcollection.cpp
> +++ b/playlistcollection.cpp
> @@ -19,7 +19,6 @@
>
>  #include <kurl.h>
>  #include <kiconloader.h>
> -#include <kinputdialog.h>
>  #include <kmessagebox.h>
>  #include <kfiledialog.h>
>  #include <kactioncollection.h>
> @@ -36,6 +35,7 @@
>  #include <QMutableListIterator>
>  #include <QObject>
>  #include <QPixmap>
> +#include <QInputDialog>
>  #include <QStackedWidget>
>
>  #include <sys/types.h>
> @@ -774,9 +774,11 @@ QString PlaylistCollection::playlistNameDialog(const QString &caption,
>  {
>      bool ok;
>
> -    QString name = KInputDialog::getText(
> +    QString name = QInputDialog::getText(
> +        m_playlistStack,
>          caption,
>          i18n("Please enter a name for this playlist:"),
> +        QLineEdit::Normal,
>          forceUnique ? uniquePlaylistName(suggest) : suggest,
>          &ok);
>
>

Nice porting work, Michael! Please read KInputDialog notice on 
https://community.kde.org/Frameworks/Porting_Notes for an important 
difference between KInputDialog and QInputDialog.
[prev in list] [next in list] [prev in thread] [next in thread]