[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdevelop] plugins/custom-definesandincludes/compilerprovider: Prefer the first available compiler a
From:       Milian Wolff <null () kde ! org>
Date:       2017-09-21 12:53:24
Message-ID: E1dv0yq-0004QZ-1y () code ! kde ! org
[Download RAW message or body]

Git commit f6e3d8b92402ec1959e2e0a62226b4f6095264a5 by Milian Wolff.
Committed on 21/09/2017 at 12:51.
Pushed by mwolff into branch 'master'.

Prefer the first available compiler as default compiler

Commit 65106becddd introduced this regression: The code used to
return early when a compiler was found. The new loop to cache
the result always iterates over all compilers.

Essentially, this reverts the whole logic within the IDM: Instead
of prefering, say, Clang over GCC, it actually does the opposite
and will prefer GCC over Clang. This patch adds the missing break
to restore the old behavior.

This ensures we will once again use Clang instead of GCC by default
for includes and built-in defines. As exemplified by the recent
breakage (__has_include) when using GCC, and the history of the
shaky GCC integration, this is important for a good default
impression of KDevelop.

M  +1    -0    plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp


https://commits.kde.org/kdevelop/f6e3d8b92402ec1959e2e0a62226b4f6095264a5

diff --git a/plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp \
b/plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp index \
                affee16a3c..fe6f1032ec 100644
--- a/plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp
+++ b/plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp
@@ -179,6 +179,7 @@ CompilerPointer CompilerProvider::defaultCompiler() const
         }
 
         m_defaultProvider = compiler;
+        break;
     }
     if (!m_defaultProvider)
         m_defaultProvider = createDummyCompiler();


[prev in list] [next in list] [prev in thread] [next in thread]