[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [konsole/Applications/17.08] src: Remove delay in dragging tabs
From:       Kurt Hindenburg <null () kde ! org>
Date:       2017-09-01 2:11:54
Message-ID: E1dnbR4-0004xS-4B () code ! kde ! org
[Download RAW message or body]

Git commit 6ed3f3a71a525921d7ae997f528acc9acbdf2824 by Kurt Hindenburg.
Committed on 01/09/2017 at 02:09.
Pushed by hindenburg into branch 'Applications/17.08'.

Remove delay in dragging tabs

When one tries to drag a tab there is a lot of lag at the start of the
drag gesture. As a result the tab is likely to be trailing the mouse
pointer by inches so that figuring out where the tab will end up is
quite confusing.

BUG: 371939
Differential Revision: https://phabricator.kde.org/D7451

(cherry picked from commit 14bf3b418cc5f5f99f598b84a68f78f034b6676e)

M  +1    -1    src/ViewContainerTabBar.cpp

https://commits.kde.org/konsole/6ed3f3a71a525921d7ae997f528acc9acbdf2824

diff --git a/src/ViewContainerTabBar.cpp b/src/ViewContainerTabBar.cpp
index b335a6d4..b0dcc995 100644
--- a/src/ViewContainerTabBar.cpp
+++ b/src/ViewContainerTabBar.cpp
@@ -81,7 +81,7 @@ void ViewContainerTabBar::mouseMoveEvent(QMouseEvent *event)
     if (event->buttons() == Qt::LeftButton) {
         QPoint dragPos = _dragStart - event->pos();
         if (dragPos.manhattanLength() > QApplication::startDragDistance()
-            && _mousePressTimer->elapsed() > QApplication::startDragTime()) {
+            || _mousePressTimer->elapsed() > QApplication::startDragTime()) {
             int tab = tabAt(_dragStart);
             if (tab != -1) {
                 emit initiateDrag(tab);
[prev in list] [next in list] [prev in thread] [next in thread]