[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdev-python] duchain: Proper variable scope, adequate API
From:       Aleix Pol <null () kde ! org>
Date:       2017-07-31 23:52:18
Message-ID: E1dcKTy-0005qO-Sh () code ! kde ! org
[Download RAW message or body]

Git commit 161a8c06b2da31c9362c53546bd2192eac540fb1 by Aleix Pol.
Committed on 31/07/2017 at 23:51.
Pushed by apol into branch 'master'.

Proper variable scope, adequate API

M  +2    -3    duchain/helpers.cpp

https://commits.kde.org/kdev-python/161a8c06b2da31c9362c53546bd2192eac540fb1

diff --git a/duchain/helpers.cpp b/duchain/helpers.cpp
index 2499bf86..6416f954 100644
--- a/duchain/helpers.cpp
+++ b/duchain/helpers.cpp
@@ -452,10 +452,9 @@ QVector<QUrl> Helper::getSearchPaths(const QUrl& workingOnDocument)
         python.start(getPythonExecutablePath(project), getpath);
         python.waitForFinished(1000);
         QString pythonpath = QString::fromUtf8(python.readAllStandardOutput());
-        auto paths = pythonpath.split("$|$");
-        paths.removeAll("");
-        
+
         if ( ! pythonpath.isEmpty() ) {
+            const auto paths = pythonpath.split("$|$", QString::SkipEmptyParts);
             foreach ( const QString& path, paths ) {
                 cachedForProject.append(QUrl::fromLocalFile(path));
             }
[prev in list] [next in list] [prev in thread] [next in thread]