[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: [kdev-python] /: Cleanup
From: Aleix Pol <null () kde ! org>
Date: 2017-07-31 23:52:18
Message-ID: E1dcKTy-0005qO-Qs () code ! kde ! org
[Download RAW message or body]
Git commit 9ac18e3e70e9e8d47da5d70459f25c1707dfbb7e by Aleix Pol.
Committed on 31/07/2017 at 23:51.
Pushed by apol into branch 'master'.
Cleanup
Fix warning
Remove unneeded include
Use function pointers for connect, makes it easier to browse the code
nowadays.
M +1 -1 docfilekcm/docfilewizard.cpp
M +0 -1 pythonparsejob.cpp
M +0 -1 pythonstylechecking.cpp
https://commits.kde.org/kdev-python/9ac18e3e70e9e8d47da5d70459f25c1707dfbb7e
diff --git a/docfilekcm/docfilewizard.cpp b/docfilekcm/docfilewizard.cpp
index 5fb82582..3e71c756 100644
--- a/docfilekcm/docfilewizard.cpp
+++ b/docfilekcm/docfilewizard.cpp
@@ -177,7 +177,7 @@ bool DocfileWizard::run()
worker = new QProcess(this);
QObject::connect(worker, &QProcess::readyReadStandardError, this, \
&DocfileWizard::processScriptOutput);
QObject::connect(worker, &QProcess::readyReadStandardOutput, this, \
&DocfileWizard::processScriptOutput);
- QObject::connect(worker, SIGNAL(finished(int)), this, SLOT(processFinished(int)));
+ QObject::connect(worker, static_cast<void(QProcess::*)(int)>(&QProcess::finished), this, \
&DocfileWizard::processFinished);
// can never have too many slashes
outputFile.setFileName(workingDirectory + "/" + outputFilename);
diff --git a/pythonparsejob.cpp b/pythonparsejob.cpp
index fcf12457..c4e81486 100644
--- a/pythonparsejob.cpp
+++ b/pythonparsejob.cpp
@@ -55,7 +55,6 @@
#include <ktexteditor/document.h>
#include <QReadLocker>
-#include <QFile>
#include <QThread>
#include <QCoreApplication>
#include <QProcess>
diff --git a/pythonstylechecking.cpp b/pythonstylechecking.cpp
index fdf0ded2..fae78388 100644
--- a/pythonstylechecking.cpp
+++ b/pythonstylechecking.cpp
@@ -133,7 +133,6 @@ void StyleChecking::processOutputStarted()
size_d = m_checkerProcess.read(10);
bool ok;
auto size = size_d.toInt(&ok);
- auto origSize = size;
if ( !ok || size < 0 ) {
addSetupErrorToContext("Got invalid size: " + size_d);
m_mutex.unlock();
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic