[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kreport] src/wrtembed: Fix recursion crash when item is smaller than scene
From:       Adam Pigg <null () kde ! org>
Date:       2017-07-24 20:36:57
Message-ID: E1dZk65-0001go-V1 () code ! kde ! org
[Download RAW message or body]

Git commit 4d79eb358aa03ef66b57c0f18a4bf908f3b3439f by Adam Pigg.
Committed on 24/07/2017 at 20:36.
Pushed by piggz into branch 'master'.

Fix recursion crash when item is smaller than scene

Task: T6558

M  +2    -3    src/wrtembed/KReportDesignerItemRectBase.cpp

https://commits.kde.org/kreport/4d79eb358aa03ef66b57c0f18a4bf908f3b3439f

diff --git a/src/wrtembed/KReportDesignerItemRectBase.cpp b/src/wrtembed/KReportDesignerItemRectBase.cpp
index 060ceb7..52d44f1 100644
--- a/src/wrtembed/KReportDesignerItemRectBase.cpp
+++ b/src/wrtembed/KReportDesignerItemRectBase.cpp
@@ -290,9 +290,8 @@ QVariant KReportDesignerItemRectBase::itemChange(GraphicsItemChange change, cons
 
             return newPos;
         } else if (change == ItemPositionHasChanged) {
-            item()->setPosition(KReportItemBase::positionFromScene(value.toPointF()));
-            //TODO dont update property
-            //m_ppos->setScenePos(value.toPointF(), KReportPosition::DontUpdateProperty);
+            setSceneRect(value.toPointF(),
+                 KReportItemBase::sceneSize(item()->size()), SceneRectFlag::DontUpdateProperty);
         } else if (change == ItemSceneHasChanged && item()) {
             QPointF newPos = pos();
 
[prev in list] [next in list] [prev in thread] [next in thread]