[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kwin/Plasma/5.10] libkwineffects: Skip Shader self test for Mesa >= 17
From:       Martin_Flöser <null () kde ! org>
Date:       2017-07-01 6:20:37
Message-ID: E1dRBll-00017H-Gc () code ! kde ! org
[Download RAW message or body]

Git commit 43816119e9ec74df228b42163b087e51b7541884 by Martin Flöser.
Committed on 01/07/2017 at 06:19.
Pushed by graesslin into branch 'Plasma/5.10'.

Skip Shader self test for Mesa >= 17

Summary:
We are getting reports about the shader self test failing in a false
positive way on Mesa 17. We already have such false positve results
for NVIDIA quadro and went with disabling the self test.

Most likely our self test has a problem or the rendering of the first
frame has a problem. But disabling compositing because our rendering of
the first frame is broken, is too much.

Let's better be pro user here and disable the shader self test till we
fixed the root problem.

BUG: 376801
FIXED-IN: 5.10.4

Test Plan: It compiles.

Reviewers: #kwin, #plasma

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D6426

M  +4    -0    libkwineffects/kwinglutils.cpp

https://commits.kde.org/kwin/43816119e9ec74df228b42163b087e51b7541884

diff --git a/libkwineffects/kwinglutils.cpp b/libkwineffects/kwinglutils.cpp
index cbf2a7484..8f7ce38ca 100644
--- a/libkwineffects/kwinglutils.cpp
+++ b/libkwineffects/kwinglutils.cpp
@@ -614,6 +614,10 @@ bool ShaderManager::selfTest()
         qCWarning(LIBKWINGLUTILS) << "Skipping self test as it is reported to return \
false positive results on Quadro hardware";  return true;
     }
+    if (GLPlatform::instance()->isMesaDriver() && \
GLPlatform::instance()->mesaVersion() >= kVersionNumber(17, 0)) { +        \
qCWarning(LIBKWINGLUTILS) << "Skipping self test as it is reported to return false \
positive results on Mesa drivers"; +        return true;
+    }
 
     // Create the source texture
     QImage image(2, 2, QImage::Format_ARGB32_Premultiplied);


[prev in list] [next in list] [prev in thread] [next in thread]