[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [plasma-workspace/Plasma/5.10] lookandfeel/contents/lockscreen: [lookandfeel/lockscreen] Fix state h
From:       Martin_Flöser <null () kde ! org>
Date:       2017-07-01 6:17:30
Message-ID: E1dRBik-0004cy-3J () code ! kde ! org
[Download RAW message or body]

Git commit 5004afe62d165af36d1fc97b138432fb0d6893a4 by Martin Flöser.
Committed on 30/06/2017 at 18:08.
Pushed by graesslin into branch 'Plasma/5.10'.

[lookandfeel/lockscreen] Fix state handling when clicking the keyboard's own hide \
button

Summary:
When clicking the hide button provided by the virtual keyboard, the
keyboard hides, but the state is not updated. This means the animation
for hide is not triggered and even more important the next call to
showHide sets a wrong state. The state assumes it is in visible, when
clicking it goes to hidden. So the virtual keyboard is not getting shown
when clicking the show virtual keyboard button.

To address this problem a change handler for keyboardActive is added
which ensures the state is correct whenever the keyboardActive value
changes.

BUG: 381833
FIXED-IN: 5.10.4

Reviewers: #plasma, sitter

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D6456

M  +8    -0    lookandfeel/contents/lockscreen/LockScreenUi.qml

https://commits.kde.org/plasma-workspace/5004afe62d165af36d1fc97b138432fb0d6893a4

diff --git a/lookandfeel/contents/lockscreen/LockScreenUi.qml \
b/lookandfeel/contents/lockscreen/LockScreenUi.qml index ddce84ee..e78b7897 100644
--- a/lookandfeel/contents/lockscreen/LockScreenUi.qml
+++ b/lookandfeel/contents/lockscreen/LockScreenUi.qml
@@ -198,6 +198,14 @@ PlasmaCore.ColorScope {
                 state = state == "hidden" ? "visible" : "hidden";
             }
             Component.onCompleted: inputPanel.source = \
"../components/VirtualKeyboard.qml" +
+            onKeyboardActiveChanged: {
+                if (keyboardActive) {
+                    state = "visible";
+                } else {
+                    state = "hidden";
+                }
+            }
             
             states: [
                 State {


[prev in list] [next in list] [prev in thread] [next in thread]