[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kreport/3.0] src/wrtembed: Address review comments.
From:       Adam Pigg <null () kde ! org>
Date:       2017-05-24 18:40:00
Message-ID: E1dDbCS-0002HN-2Z () code ! kde ! org
[Download RAW message or body]

Git commit ada91f64341745473ae04d60768e6582e87dae01 by Adam Pigg.
Committed on 24/05/2017 at 18:37.
Pushed by piggz into branch '3.0'.

Address review comments.

Reset margins
Set label buddy

M  +0    -2    src/wrtembed/KReportDetailGroupSectionDialog.h
M  +9    -12   src/wrtembed/KReportDetailGroupSectionDialog.ui

https://commits.kde.org/kreport/ada91f64341745473ae04d60768e6582e87dae01

diff --git a/src/wrtembed/KReportDetailGroupSectionDialog.h \
b/src/wrtembed/KReportDetailGroupSectionDialog.h index 04385ad..ceb7e1d 100644
--- a/src/wrtembed/KReportDetailGroupSectionDialog.h
+++ b/src/wrtembed/KReportDetailGroupSectionDialog.h
@@ -20,7 +20,6 @@
 #define DETAILGROUPSECTIONDIALOG_H
 
 #include <QDialog>
-#include <QDialogButtonBox>
 
 #include <ui_KReportDetailGroupSectionDialog.h>
 
@@ -31,7 +30,6 @@ class KReportDetailGroupSectionDialog : public QDialog, public \
Ui::DetailGroupSe  public:
     explicit KReportDetailGroupSectionDialog(QWidget* parent = nullptr);
     ~KReportDetailGroupSectionDialog() override;
-
 };
 
 #endif // DETAILGROUPSECTIONDIALOG_H
diff --git a/src/wrtembed/KReportDetailGroupSectionDialog.ui \
b/src/wrtembed/KReportDetailGroupSectionDialog.ui index 2f9b32d..cfbd775 100644
--- a/src/wrtembed/KReportDetailGroupSectionDialog.ui
+++ b/src/wrtembed/KReportDetailGroupSectionDialog.ui
@@ -28,18 +28,6 @@
    </rect>
   </property>
   <layout class="QFormLayout" name="formLayout">
-   <property name="leftMargin">
-    <number>0</number>
-   </property>
-   <property name="topMargin">
-    <number>0</number>
-   </property>
-   <property name="rightMargin">
-    <number>0</number>
-   </property>
-   <property name="bottomMargin">
-    <number>0</number>
-   </property>
    <item row="0" column="0">
     <widget class="QLabel" name="lblColumn">
      <property name="text">
@@ -79,6 +67,9 @@
      <property name="text">
       <string>Show group header:</string>
      </property>
+     <property name="buddy">
+      <cstring>cbHead</cstring>
+     </property>
     </widget>
    </item>
    <item row="2" column="1">
@@ -93,6 +84,9 @@
      <property name="text">
       <string>Show group footer:</string>
      </property>
+     <property name="buddy">
+      <cstring>cbFoot</cstring>
+     </property>
     </widget>
    </item>
    <item row="3" column="1">
@@ -110,6 +104,9 @@
      <property name="text">
       <string>Insert page break after group footer:</string>
      </property>
+     <property name="buddy">
+      <cstring>breakAfterFooter</cstring>
+     </property>
     </widget>
    </item>
    <item row="4" column="1">


[prev in list] [next in list] [prev in thread] [next in thread]