[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kbibtex] src/program: Showing search results docklet on data returned from Zotero
From:       Thomas Fischer <null () kde ! org>
Date:       2017-03-31 21:56:22
Message-ID: E1cu4Ws-0004Se-BN () code ! kde ! org
[Download RAW message or body]

Git commit 770951260f9d907501a8e44d5139d2f8d406ab51 by Thomas Fischer.
Committed on 31/03/2017 at 19:29.
Pushed by thomasfischer into branch 'master'.

Showing search results docklet on data returned from Zotero

Fixing a minor issue as reported in comment 6 of
KDE bug report 377401:

"However, the search results panel doesn't open when I
double click on the zotero library. It only shows
results if I did an online search before and when the
search panel is opened. If I close the search panel
it doesn't appear when double clicking the library."

This commit is a manual forward port of commit e89ca1bbbcfa
from branch 'kbibtex/0.7'.

M  +1    -0    src/program/docklets/zoterobrowser.cpp
M  +3    -0    src/program/docklets/zoterobrowser.h
M  +1    -0    src/program/mainwindow.cpp

https://commits.kde.org/kbibtex/770951260f9d907501a8e44d5139d2f8d406ab51

diff --git a/src/program/docklets/zoterobrowser.cpp \
b/src/program/docklets/zoterobrowser.cpp index be0bd5ef..e33d449a 100644
--- a/src/program/docklets/zoterobrowser.cpp
+++ b/src/program/docklets/zoterobrowser.cpp
@@ -261,6 +261,7 @@ void ZoteroBrowser::tagDoubleClicked(const QModelIndex &index)
 void ZoteroBrowser::showItem(QSharedPointer<Element> e)
 {
     d->searchResults->insertElement(e);
+    emit itemToShow();
 }
 
 void ZoteroBrowser::reenableWidget()
diff --git a/src/program/docklets/zoterobrowser.h \
b/src/program/docklets/zoterobrowser.h index 5c946a3d..6e30a849 100644
--- a/src/program/docklets/zoterobrowser.h
+++ b/src/program/docklets/zoterobrowser.h
@@ -38,6 +38,9 @@ public:
 public slots:
     void visibiltyChanged(bool);
 
+signals:
+    void itemToShow();
+
 private:
     class Private;
     Private *const d;
diff --git a/src/program/mainwindow.cpp b/src/program/mainwindow.cpp
index e9f1670e..ea932244 100644
--- a/src/program/mainwindow.cpp
+++ b/src/program/mainwindow.cpp
@@ -173,6 +173,7 @@ public:
         p->addDockWidget(Qt::LeftDockWidgetArea, dockZotero);
         zotero = new ZoteroBrowser(searchResults, dockZotero);
         connect(dockZotero, &QDockWidget::visibilityChanged, zotero, \
&ZoteroBrowser::visibiltyChanged); +        connect(zotero, \
&ZoteroBrowser::itemToShow, p, &KBibTeXMainWindow::showSearchResults);  \
dockZotero->setWidget(zotero);  \
                dockZotero->setObjectName(QStringLiteral("dockZotero"));
         dockZotero->setFeatures(QDockWidget::DockWidgetClosable | \
QDockWidget::DockWidgetMovable | QDockWidget::DockWidgetFloatable);


[prev in list] [next in list] [prev in thread] [next in thread]