[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [dolphin] src: Time to get back to business
From:       Emmanuel Pescosta <emmanuelpescosta099 () gmail ! com>
Date:       2017-02-13 17:01:49
Message-ID: CAH3KK-VXD8mMqA=LK42wTj1k1RgLxttu7Ms+qCiLxMMpcSzHRg () mail ! gmail ! com
[Download RAW message or body]

Please consider to squash all your commits which are related to one single
issue into a single commit the next time ;)

Cheers,
Emmanuel

2017-02-13 17:55 GMT+01:00 arnav dhamija <null@kde.org>:

> Git commit 68cda76aa8f552246db136fa61303f9678cea7e7 by arnav dhamija.
> Committed on 29/01/2017 at 16:30.
> Pushed by arnavdhamija into branch 'master'.
>
> Time to get back to business
>
> M  +0    -1    src/dolphinmainwindow.cpp
>
> https://commits.kde.org/dolphin/68cda76aa8f552246db136fa61303f9678cea7e7
>
> diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp
> index 55577e27b5..412d4fb2e2 100644
> --- a/src/dolphinmainwindow.cpp
> +++ b/src/dolphinmainwindow.cpp
> @@ -528,7 +528,6 @@ void DolphinMainWindow::toggleSplitStash()
>  {
>      DolphinTabPage* tabPage = m_tabWidget->currentTabPage();
>      QAction* stashSplit = actionCollection()->action(
> QStringLiteral("split_stash"));
> -    qDebug() << "StashSplitstate" << stashSplit->isChecked();
>      //stashSplit->setEnabled(false);
>      if (stashSplit->isChecked()) {
>          tabPage->setSplitViewEnabled(false);
>
>

[Attachment #3 (text/html)]

<div dir="ltr"><div><div>Please consider to squash all your commits which are related \
to one single <br>issue into a single commit the next time ;)<br><br></div>Cheers, \
<br></div>Emmanuel<br></div><div class="gmail_extra"><br><div \
class="gmail_quote">2017-02-13 17:55 GMT+01:00 arnav dhamija <span dir="ltr">&lt;<a \
href="mailto:null@kde.org" \
target="_blank">null@kde.org</a>&gt;</span>:<br><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Git commit \
68cda76aa8f552246db136fa61303f<wbr>9678cea7e7 by arnav dhamija.<br> Committed on \
29/01/2017 at 16:30.<br> Pushed by arnavdhamija into branch &#39;master&#39;.<br>
<br>
Time to get back to business<br>
<br>
M   +0      -1      src/dolphinmainwindow.cpp<br>
<br>
<a href="https://commits.kde.org/dolphin/68cda76aa8f552246db136fa61303f9678cea7e7" \
rel="noreferrer" target="_blank">https://commits.kde.org/<wbr>dolphin/<wbr>68cda76aa8f552246db136fa61303f<wbr>9678cea7e7</a><br>
 <br>
diff --git a/src/dolphinmainwindow.cpp b/src/dolphinmainwindow.cpp<br>
index 55577e27b5..412d4fb2e2 100644<br>
--- a/src/dolphinmainwindow.cpp<br>
+++ b/src/dolphinmainwindow.cpp<br>
@@ -528,7 +528,6 @@ void DolphinMainWindow::<wbr>toggleSplitStash()<br>
  {<br>
        DolphinTabPage* tabPage = m_tabWidget-&gt;currentTabPage();<br>
        QAction* stashSplit = \
                actionCollection()-&gt;action(<wbr>QStringLiteral(&quot;split_stash&quot;))<wbr>;<br>
                
-      qDebug() &lt;&lt; &quot;StashSplitstate&quot; &lt;&lt; \
stashSplit-&gt;isChecked();<br>  //stashSplit-&gt;setEnabled(<wbr>false);<br>
        if (stashSplit-&gt;isChecked()) {<br>
              tabPage-&gt;setSplitViewEnabled(<wbr>false);<br>
<br>
</blockquote></div><br></div>



[prev in list] [next in list] [prev in thread] [next in thread]