[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [plasma-workspace] runners/services: do not explicitly check NotShownIn it's not necessary and incom
From:       Harald Sitter <null () kde ! org>
Date:       2016-12-16 13:28:19
Message-ID: E1cHsYd-0006HD-A3 () code ! kde ! org
[Download RAW message or body]

Git commit b9ac84508645b752254f712062984bdcde0a5025 by Harald Sitter.
Committed on 16/12/2016 at 13:28.
Pushed by sitter into branch 'master'.

do not explicitly check NotShownIn it's not necessary and incomplete

Summary:
KService::noDisplay() includes qualification for
- NoDisplay entry itself
- OnlyShowIn and NotShowIn
- X-KDE-OnlyShowOnQtPlatforms
- authorization WRT KCMs

as such checking nodisplay is good enough to disqualify services in all
relevant scenarios

Test Plan: - read the code of noDisplay()

Reviewers: broulik

Reviewed By: broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3705

M  +1    -1    runners/services/servicerunner.cpp

https://commits.kde.org/plasma-workspace/b9ac84508645b752254f712062984bdcde0a5025

diff --git a/runners/services/servicerunner.cpp b/runners/services/servicerunner.cpp
index 411107cc..13aec90f 100644
--- a/runners/services/servicerunner.cpp
+++ b/runners/services/servicerunner.cpp
@@ -121,7 +121,7 @@ private:
 
         foreach (const KService::Ptr &service, services) {
             qCDebug(RUNNER_SERVICES) << service->name() << "is an exact match!" << \
                service->storageId() << service->exec();
-            if (service->noDisplay() || \
service->property(QStringLiteral("NotShowIn"), QVariant::String) == "KDE") { +        \
if (service->noDisplay()) {  continue;
             }
             Plasma::QueryMatch match(m_runner);


[prev in list] [next in list] [prev in thread] [next in thread]