[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdenlive] src: Clean up code. const'ify some method
From:       Montel Laurent <montel () kde ! org>
Date:       2016-12-08 12:38:06
Message-ID: E1cExxe-0004pX-Vg () code ! kde ! org
[Download RAW message or body]

Git commit ed60ba9ebf045be7bd8e57d2f89a5e41954a5f27 by Montel Laurent.
Committed on 08/12/2016 at 12:37.
Pushed by mlaurent into branch 'master'.

Clean up code. const'ify some method

M  +3    -3    src/project/clipstabilize.cpp
M  +3    -3    src/project/clipstabilize.h
M  +1    -1    src/renderer.h
M  +4    -0    src/timecode.cpp
M  +1    -3    src/timecode.h

https://commits.kde.org/kdenlive/ed60ba9ebf045be7bd8e57d2f89a5e41954a5f27

diff --git a/src/project/clipstabilize.cpp b/src/project/clipstabilize.cpp
index 56c306f6e..c83e73a53 100644
--- a/src/project/clipstabilize.cpp
+++ b/src/project/clipstabilize.cpp
@@ -125,12 +125,12 @@ ClipStabilize::~ClipStabilize()
     KdenliveSettings::setAdd_new_clip(auto_add->isChecked());
 }
 
-QMap<QString, QString> ClipStabilize::producerParams()
+QMap<QString, QString> ClipStabilize::producerParams() const
 {
     return QMap<QString, QString>();
 }
 
-QMap<QString, QString> ClipStabilize::filterParams()
+QMap<QString, QString> ClipStabilize::filterParams() const
 {
     QMap<QString, QString> params;
     params.insert(QStringLiteral("filter"), m_filtername);
@@ -149,7 +149,7 @@ QMap<QString, QString> ClipStabilize::filterParams()
     return params;
 }
 
-QMap<QString, QString> ClipStabilize::consumerParams()
+QMap<QString, QString> ClipStabilize::consumerParams() const
 {
     // consumer params
     QMap<QString, QString> params;
diff --git a/src/project/clipstabilize.h b/src/project/clipstabilize.h
index 0a392a67b..74ef131d9 100644
--- a/src/project/clipstabilize.h
+++ b/src/project/clipstabilize.h
@@ -35,11 +35,11 @@ public:
     /** @brief Should the generated clip be added to current project. */
     bool autoAddClip() const;
     /** @brief Return the producer parameters, producer name as value of "producer" entry. */
-    QMap<QString, QString> producerParams();
+    QMap<QString, QString> producerParams() const;
     /** @brief Return the filter parameters, filter name as value of "filter" entry. */
-    QMap<QString, QString> filterParams();
+    QMap<QString, QString> filterParams() const;
     /** @brief Return the consumer parameters, consumer name as value of "consumer" entry. */
-    QMap<QString, QString> consumerParams();
+    QMap<QString, QString> consumerParams() const;
     /** @brief Return the destination file or folder. */
     QString destination() const;
     /** @brief Return the job description. */
diff --git a/src/renderer.h b/src/renderer.h
index f44d05385..7534accbf 100644
--- a/src/renderer.h
+++ b/src/renderer.h
@@ -335,7 +335,7 @@ signals:
     /** @brief A frame's image has to be shown.
      *
      * Used in Mac OS X. */
-    void showImageSignal(QImage);
+    void showImageSignal(const QImage &);
     void showAudioSignal(const QVector<double> &);
     void checkSeeking();
     /** @brief Activate current monitor. */
diff --git a/src/timecode.cpp b/src/timecode.cpp
index 0c307dd75..17ccce27d 100644
--- a/src/timecode.cpp
+++ b/src/timecode.cpp
@@ -106,6 +106,10 @@ void Timecode::setFormat(double framesPerSecond, Formats format)
     }
 }
 
+Timecode::Formats Timecode::format() const {
+    return m_format;
+}
+
 double Timecode::fps() const
 {
     return m_realFps;
diff --git a/src/timecode.h b/src/timecode.h
index ab0680d95..58456d6b9 100644
--- a/src/timecode.h
+++ b/src/timecode.h
@@ -38,9 +38,7 @@ public:
      */
     void setFormat(double framesPerSecond, Formats format = HH_MM_SS_FF);
 
-    Formats format() const {
-        return m_format;
-    }
+    Formats format() const;
 
     ~Timecode();
 
[prev in list] [next in list] [prev in thread] [next in thread]