[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [k3b/cdrskin] libk3b/projects: Change arguments for Cdrskin
From:       Leslie Zhai <xiangzhai83 () gmail ! com>
Date:       2016-12-02 2:17:10
Message-ID: E1cCdPS-0005zg-44 () code ! kde ! org
[Download RAW message or body]

Git commit a8074105e842babab18d7adcb290dd6eca3304bb by Leslie Zhai.
Committed on 02/12/2016 at 02:07.
Pushed by lesliezhai into branch 'cdrskin'.

Change arguments for Cdrskin

Use libburn git version 19a1b8e768e393ea0476c1a7224c58599f30628b
Bug fix: Option -dummy did not affect writing by direct_write_amount=

patch -Np1 -i Libburn_cdemu_host_status_test.patch

Test plan1:
1. cdemu create-blank --writer-id=WRITER-ISO --medium-type=dvd+r 0
~/virt.iso
2. dd if=/dev/zero bs=2048 count=375808 | /usr/sbin/cdrskin -v dev=/dev/sr1
speed=18 -tao -data -tsize=375808s - >/tmp/cdrskin.log 2>&1
SUCCESS: cdrskin3.log

Test plan2:
1. cdemu create-blank --writer-id=WRITER-ISO --medium-type=dvd+r 0
~/virt.iso
2. k3b burn ArchLinux iso
FAILED: cdrskin-burn-archlinux-iso-debugging-output4.txt

Test plan3:
1. cdemu create-blank --writer-id=WRITER-ISO --medium-type=dvd+r 0
~/virt.iso
2. dd if=/dev/zero bs=2048 count=375808 | /usr/bin/cdrecord -d -v -V
gracetime=2 dev=/dev/sr1 speed=18 -sao driveropts=burnfree -data
-tsize=375808s - >/tmp/cdrecord.log 2>&1
SUCCESS: cdrecord.log.tar.bz2

CCMAIL: scdbackup@gmx.net
CCBUG: 137436

M  +4    -3    libk3b/projects/k3bcdrskinwriter.cpp

https://commits.kde.org/k3b/a8074105e842babab18d7adcb290dd6eca3304bb

diff --git a/libk3b/projects/k3bcdrskinwriter.cpp b/libk3b/projects/k3bcdrskinwriter.cpp
index e73d739..dfedc8c 100644
--- a/libk3b/projects/k3bcdrskinwriter.cpp
+++ b/libk3b/projects/k3bcdrskinwriter.cpp
@@ -257,7 +257,10 @@ bool K3b::CdrskinWriter::prepareProcess()
         //
         // One may omit both -tao and -sao in order to let cdrskin decide on base
         // of -multi, input source and Medium state which write type to use.
-        d->process << "-tao"/* << "-sao"*/;
+#ifdef K3B_DEBUG
+        qDebug() << "DEBUG:" << __PRETTY_FUNCTION__ << "let libburn choose "
+            "the write type according to other parameters and the medium state.";
+#endif
     }
     else if( K3b::Device::isCdMedia( d->burnedMediaType ) ) {
         if( d->writingMode == K3b::WritingModeSao || d->cue ) {
@@ -276,8 +279,6 @@ bool K3b::CdrskinWriter::prepareProcess()
             // Options -xa1, -xa, -xa2, -mode2 do not lead to error but the payload is
             // nevertheless written as -data.
             emit infoMessage(i18n("Writer does not support raw writing."), MessageWarning);
-            if (d->cdrskinBinObject->hasFeature("tao"))
-                d->process << "-tao";
         }
         else if( d->cdrskinBinObject->hasFeature( "tao" ) )
             d->process << "-tao";
[prev in list] [next in list] [prev in thread] [next in thread]