[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [marble] src/lib/marble/geodata/graphicsitem: Do not create useless copies
From:       Dennis_Nienhüser <nienhueser () kde ! org>
Date:       2016-11-30 20:43:15
Message-ID: E1cCBil-0008LR-C1 () code ! kde ! org
[Download RAW message or body]

Git commit a4b6c2975fdc9f15d08f36e0b81de4c86546cf9a by Dennis Nienhüser.
Committed on 30/11/2016 at 20:43.
Pushed by nienhueser into branch 'master'.

Do not create useless copies

M  +1    -1    src/lib/marble/geodata/graphicsitem/AbstractGeoPolygonGraphicsItem.cpp
M  +1    -1    src/lib/marble/geodata/graphicsitem/BuildingGeoPolygonGraphicsItem.cpp

https://commits.kde.org/marble/a4b6c2975fdc9f15d08f36e0b81de4c86546cf9a

diff --git a/src/lib/marble/geodata/graphicsitem/AbstractGeoPolygonGraphicsItem.cpp \
b/src/lib/marble/geodata/graphicsitem/AbstractGeoPolygonGraphicsItem.cpp index \
                a60439b..fd863d0 100644
--- a/src/lib/marble/geodata/graphicsitem/AbstractGeoPolygonGraphicsItem.cpp
+++ b/src/lib/marble/geodata/graphicsitem/AbstractGeoPolygonGraphicsItem.cpp
@@ -66,7 +66,7 @@ void AbstractGeoPolygonGraphicsItem::paint( GeoPainter* painter, \
const ViewportP  configurePainter(painter, viewport);
     if ( m_polygon ) {
         bool innerResolved = false;
-        for(auto ring : m_polygon->innerBoundaries()) {
+        for(auto const & ring : m_polygon->innerBoundaries()) {
             if (viewport->resolves(ring.latLonAltBox(), 4)) {
                innerResolved = true;
                break;
diff --git a/src/lib/marble/geodata/graphicsitem/BuildingGeoPolygonGraphicsItem.cpp \
b/src/lib/marble/geodata/graphicsitem/BuildingGeoPolygonGraphicsItem.cpp index \
                7910824..d5d89d2 100644
--- a/src/lib/marble/geodata/graphicsitem/BuildingGeoPolygonGraphicsItem.cpp
+++ b/src/lib/marble/geodata/graphicsitem/BuildingGeoPolygonGraphicsItem.cpp
@@ -490,7 +490,7 @@ void BuildingGeoPolygonGraphicsItem::screenPolygons(const \
ViewportParams *viewpo  
     viewport->screenCoordinates( polygon->outerBoundary(), outerPolygons );
 
-    QVector<GeoDataLinearRing> innerBoundaries = polygon->innerBoundaries();
+    QVector<GeoDataLinearRing> const & innerBoundaries = polygon->innerBoundaries();
     foreach (const GeoDataLinearRing &innerBoundary, innerBoundaries) {
         QVector<QPolygonF*> innerPolygonsPerBoundary;
         viewport->screenCoordinates(innerBoundary, innerPolygonsPerBoundary);


[prev in list] [next in list] [prev in thread] [next in thread]