[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-commits
Subject: [kdenlive] src: Continue to add const'ref
From: Montel Laurent <montel () kde ! org>
Date: 2016-11-30 20:18:49
Message-ID: E1cCBL7-0001Jr-TN () code ! kde ! org
[Download RAW message or body]
Git commit fe293eca4ba67db73430d9fe6fa60dab543ea160 by Montel Laurent.
Committed on 30/11/2016 at 20:18.
Pushed by mlaurent into branch 'master'.
Continue to add const'ref
M +1 -1 src/bin/bin.cpp
M +1 -1 src/bin/bin.h
M +1 -0 src/bin/bincommands.cpp
M +3 -3 src/dialogs/renderwidget.cpp
M +3 -3 src/dialogs/renderwidget.h
M +1 -1 src/doc/documentchecker.cpp
M +1 -1 src/doc/documentchecker.h
M +1 -1 src/doc/kdenlivedoc.cpp
M +1 -1 src/doc/kdenlivedoc.h
M +2 -1 src/effectslist/initeffects.cpp
M +3 -3 src/effectslist/initeffects.h
M +1 -1 src/effectstack/widgets/animationwidget.cpp
M +1 -1 src/effectstack/widgets/animationwidget.h
M +1 -1 src/effectstack/widgets/colorwheel.cpp
M +1 -1 src/effectstack/widgets/colorwheel.h
M +1 -1 src/effectstack/widgets/cornerswidget.cpp
M +1 -1 src/effectstack/widgets/cornerswidget.h
M +1 -1 src/effectstack/widgets/geometrywidget.cpp
M +1 -1 src/effectstack/widgets/geometrywidget.h
M +1 -1 src/effectstack/widgets/selectivecolor.cpp
M +1 -1 src/effectstack/widgets/selectivecolor.h
M +2 -2 src/monitor/glwidget.cpp
M +2 -2 src/monitor/glwidget.h
M +6 -5 src/monitor/monitor.cpp
M +5 -5 src/monitor/monitor.h
M +1 -1 src/monitor/monitormanager.cpp
M +1 -1 src/monitor/monitormanager.h
M +1 -1 src/project/clipmanager.cpp
M +1 -1 src/project/clipmanager.h
M +1 -1 src/project/jobs/cutclipjob.cpp
M +1 -1 src/project/jobs/cutclipjob.h
M +1 -1 src/renderer.cpp
M +1 -1 src/renderer.h
M +2 -2 src/timeline/clipitem.cpp
M +2 -2 src/timeline/clipitem.h
M +1 -1 src/timeline/customtrackview.cpp
M +1 -1 src/timeline/customtrackview.h
M +1 -1 src/timeline/effectmanager.cpp
M +1 -1 src/timeline/effectmanager.h
M +1 -1 src/timeline/keyframeview.cpp
M +1 -1 src/timeline/keyframeview.h
M +1 -1 src/timeline/managers/previewmanager.cpp
M +1 -1 src/timeline/managers/previewmanager.h
M +2 -2 src/timeline/managers/trimmanager.cpp
M +2 -2 src/timeline/managers/trimmanager.h
M +3 -3 src/timeline/timeline.cpp
M +3 -3 src/timeline/timeline.h
M +1 -1 src/timeline/timelinecommands.cpp
M +1 -1 src/timeline/timelinecommands.h
M +2 -2 src/timeline/transitionhandler.cpp
M +2 -2 src/timeline/transitionhandler.h
M +1 -1 src/titler/gradientwidget.cpp
M +1 -1 src/titler/gradientwidget.h
M +1 -1 src/titler/titlewidget.cpp
M +1 -1 src/titler/titlewidget.h
M +1 -1 src/utils/progressbutton.cpp
M +1 -1 src/utils/progressbutton.h
M +3 -3 src/utils/resourcewidget.cpp
M +3 -3 src/utils/resourcewidget.h
https://commits.kde.org/kdenlive/fe293eca4ba67db73430d9fe6fa60dab543ea160
diff --git a/src/bin/bin.cpp b/src/bin/bin.cpp
index 5b5450a..ed6c39c 100644
--- a/src/bin/bin.cpp
+++ b/src/bin/bin.cpp
@@ -2752,7 +2752,7 @@ void Bin::slotAddClipCut(const QString&id, int in, int out)
m_doc->commandStack()->push(command);
}
-void Bin::loadSubClips(const QString&id, const QMap <QString,QString> data)
+void Bin::loadSubClips(const QString&id, const QMap <QString,QString> &data)
{
ProjectClip *clip = getBinClip(id);
if (!clip) return;
diff --git a/src/bin/bin.h b/src/bin/bin.h
index 476cf89..8cd8bcb 100644
--- a/src/bin/bin.h
+++ b/src/bin/bin.h
@@ -459,7 +459,7 @@ public:
void removeClipCut(const QString&id, int in, int out);
/** @brief Create the subclips defined in the parent clip. */
- void loadSubClips(const QString&id, const QMap <QString,QString> data);
+ void loadSubClips(const QString&id, const QMap<QString, QString> &data);
/** @brief Set focus to the Bin view. */
void focusBinView() const;
diff --git a/src/bin/bincommands.cpp b/src/bin/bincommands.cpp
index 50dc857..7d4d7a3 100644
--- a/src/bin/bincommands.cpp
+++ b/src/bin/bincommands.cpp
@@ -205,6 +205,7 @@ MoveBinEffectCommand::MoveBinEffectCommand(Bin *bin, const \
QString &clipId, cons m_clipId(clipId),
m_oldindex(oldPos)
{
+ m_newindex.reserve(m_oldindex.count());
for (int i = 0; i < m_oldindex.count(); ++i) {
m_newindex << newPos + i;
}
diff --git a/src/dialogs/renderwidget.cpp b/src/dialogs/renderwidget.cpp
index ec8bdd1..d4a93a8 100644
--- a/src/dialogs/renderwidget.cpp
+++ b/src/dialogs/renderwidget.cpp
@@ -389,7 +389,7 @@ void RenderWidget::slotCheckEndGuidePosition()
m_view.guide_end->setCurrentIndex(m_view.guide_start->currentIndex());
}
-void RenderWidget::setGuides(QMap <double, QString> guidesData, double duration)
+void RenderWidget::setGuides(const QMap <double, QString> &guidesData, double \
duration) {
m_view.guide_start->clear();
m_view.guide_end->clear();
@@ -934,7 +934,7 @@ void RenderWidget::focusFirstVisibleItem(const QString &profile)
updateButtons();
}
-void RenderWidget::slotPrepareExport(bool scriptExport, const QString scriptPath)
+void RenderWidget::slotPrepareExport(bool scriptExport, const QString &scriptPath)
{
if (!QFile::exists(KdenliveSettings::rendererpath())) {
KMessageBox::sorry(this, i18n("Cannot find the melt program required for \
rendering (part of Mlt)")); @@ -1785,7 +1785,7 @@ void \
RenderWidget::parseMltPresets() }
}
-QTreeWidgetItem *RenderWidget::loadFromMltPreset(const QString groupName, const \
QString path, const QString profileName) +QTreeWidgetItem \
*RenderWidget::loadFromMltPreset(const QString &groupName, const QString &path, const \
QString &profileName) {
KConfig config(path, KConfig::SimpleConfig);
KConfigGroup group = config.group(QByteArray());
diff --git a/src/dialogs/renderwidget.h b/src/dialogs/renderwidget.h
index 0778292..9be4f11 100644
--- a/src/dialogs/renderwidget.h
+++ b/src/dialogs/renderwidget.h
@@ -113,7 +113,7 @@ class RenderWidget : public QDialog
public:
explicit RenderWidget(const QString &projectfolder, bool enableProxy, const \
MltVideoProfile &profile, QWidget * parent = Q_NULLPTR); virtual ~RenderWidget();
- void setGuides(QMap <double, QString> guidesData, double duration);
+ void setGuides(const QMap<double, QString> &guidesData, double duration);
void focusFirstVisibleItem(const QString &profile = QString());
void setProfile(const MltVideoProfile& profile);
void setRenderJob(const QString &dest, int progress = 0);
@@ -153,7 +153,7 @@ public slots:
const QList<QString> &playlistPaths, const QList<QString> &trackNames,
const QString &scriptPath, bool exportAudio);
void slotAbortCurrentJob();
- void slotPrepareExport(bool scriptExport = false, QString scriptPath = \
QString()); + void slotPrepareExport(bool scriptExport = false, const QString \
&scriptPath = QString());
private slots:
void slotUpdateButtons(const QUrl &url);
@@ -219,7 +219,7 @@ private:
void startRendering(RenderJobItem *item);
bool saveProfile(QDomElement newprofile);
/** @brief Create a rendering profile from MLT preset. */
- QTreeWidgetItem *loadFromMltPreset(const QString groupName, const QString path, \
const QString profileName); + QTreeWidgetItem *loadFromMltPreset(const QString \
&groupName, const QString &path, const QString &profileName); void checkCodecs();
signals:
diff --git a/src/doc/documentchecker.cpp b/src/doc/documentchecker.cpp
index a906079..f9f2c56 100644
--- a/src/doc/documentchecker.cpp
+++ b/src/doc/documentchecker.cpp
@@ -732,7 +732,7 @@ void DocumentChecker::acceptDialog()
//QDialog::accept();
}
-void DocumentChecker::fixProxyClip(const QString &id, const QString oldUrl, const \
QString newUrl, const QDomNodeList &producers) +void \
DocumentChecker::fixProxyClip(const QString &id, const QString &oldUrl, const QString \
&newUrl, const QDomNodeList &producers) {
QDomElement e, property;
QDomNodeList properties;
diff --git a/src/doc/documentchecker.h b/src/doc/documentchecker.h
index fdb8004..1b96255 100644
--- a/src/doc/documentchecker.h
+++ b/src/doc/documentchecker.h
@@ -78,7 +78,7 @@ private:
void fixClipItem(QTreeWidgetItem *child, const QDomNodeList &producers, const \
QDomNodeList &trans);
void fixSourceClipItem(QTreeWidgetItem *child, const QDomNodeList &producers);
- void fixProxyClip(const QString &id, const QString oldUrl, const QString newUrl, \
const QDomNodeList &producers); + void fixProxyClip(const QString &id, const \
QString &oldUrl, const QString &newUrl, const QDomNodeList &producers); };
diff --git a/src/doc/kdenlivedoc.cpp b/src/doc/kdenlivedoc.cpp
index b6726f6..7662d77 100644
--- a/src/doc/kdenlivedoc.cpp
+++ b/src/doc/kdenlivedoc.cpp
@@ -738,7 +738,7 @@ QString KdenliveDoc::projectDataFolder() const
return m_projectFolder;
}
-void KdenliveDoc::setProjectFolder(QUrl url)
+void KdenliveDoc::setProjectFolder(const QUrl &url)
{
if (url == QUrl::fromLocalFile(m_projectFolder)) return;
setModified(true);
diff --git a/src/doc/kdenlivedoc.h b/src/doc/kdenlivedoc.h
index 10df69d..721c445 100644
--- a/src/doc/kdenlivedoc.h
+++ b/src/doc/kdenlivedoc.h
@@ -123,7 +123,7 @@ public:
/** @brief Saves only the MLT xml to a file for preview rendering. */
void saveMltPlaylist(const QString &fileName);
void cacheImage(const QString &fileId, const QImage &img) const;
- void setProjectFolder(QUrl url);
+ void setProjectFolder(const QUrl &url);
void setZone(int start, int end);
QPoint zone() const;
int setSceneList();
diff --git a/src/effectslist/initeffects.cpp b/src/effectslist/initeffects.cpp
index 43d1c31..4759e56 100644
--- a/src/effectslist/initeffects.cpp
+++ b/src/effectslist/initeffects.cpp
@@ -178,6 +178,7 @@ bool initEffects::parseEffectFiles(Mlt::Repository* repository, \
const QString &l Mlt::Properties *consumers = repository->consumers();
QStringList consumersList;
max = consumers->count();
+ consumersList.reserve(max);
for (int i = 0; i < max; ++i)
consumersList << consumers->get_name(i);
delete consumers;
@@ -427,7 +428,7 @@ void initEffects::parseCustomEffectsFile()
}
// static
-void initEffects::parseEffectFile(EffectsList *customEffectList, EffectsList \
*audioEffectList, EffectsList *videoEffectList, const QString &name, QStringList \
filtersList, QStringList producersList, Mlt::Repository *repository, QMap <QString, \
QString> effectDescriptions) +void initEffects::parseEffectFile(EffectsList \
*customEffectList, EffectsList *audioEffectList, EffectsList *videoEffectList, const \
QString &name, const QStringList &filtersList, const QStringList &producersList, \
Mlt::Repository *repository, const QMap <QString, QString> &effectDescriptions) {
QDomDocument doc;
QFile file(name);
diff --git a/src/effectslist/initeffects.h b/src/effectslist/initeffects.h
index 6dc52db..19acad8 100644
--- a/src/effectslist/initeffects.h
+++ b/src/effectslist/initeffects.h
@@ -86,9 +86,9 @@ public:
static void parseEffectFile(EffectsList *customEffectList,
EffectsList *audioEffectList,
EffectsList *videoEffectList,
- const QString &name, QStringList filtersList,
- QStringList producersList,
- Mlt::Repository *repository, QMap <QString, QString> \
effectDescriptions); + const QString &name, const \
QStringList &filtersList, + const QStringList \
&producersList, + Mlt::Repository *repository, const \
QMap<QString, QString> &effectDescriptions); static void \
parseTransitionFile(EffectsList *transitionList, const QString &name, Mlt::Repository \
*repository, const QStringList &installedTransitions, const QMap<QString, QString> \
&effectDescriptions);
/** @brief Reloads information about custom effects. */
diff --git a/src/effectstack/widgets/animationwidget.cpp \
b/src/effectstack/widgets/animationwidget.cpp index c9f04fb..c096618 100644
--- a/src/effectstack/widgets/animationwidget.cpp
+++ b/src/effectstack/widgets/animationwidget.cpp
@@ -1159,7 +1159,7 @@ void AnimationWidget::slotUpdateGeometryRect(const QRect r)
setupMonitor();
}
-void AnimationWidget::slotUpdateCenters(const QVariantList centers)
+void AnimationWidget::slotUpdateCenters(const QVariantList ¢ers)
{
if (centers.count() != m_animController.key_count()) {
qDebug()<<"* * * *CENTER POINTS MISMATCH, aborting edit";
diff --git a/src/effectstack/widgets/animationwidget.h \
b/src/effectstack/widgets/animationwidget.h index 2953e2d..45b5122 100644
--- a/src/effectstack/widgets/animationwidget.h
+++ b/src/effectstack/widgets/animationwidget.h
@@ -138,7 +138,7 @@ private slots:
void slotSetDefaultInterp(QAction *action);
void slotUpdateVisibleParameter(bool display);
void slotUpdateGeometryRect(const QRect r);
- void slotUpdateCenters(const QVariantList centers);
+ void slotUpdateCenters(const QVariantList ¢ers);
void slotSeekToKeyframe(int ix);
void slotAdjustToSource();
void slotAdjustToFrameSize();
diff --git a/src/effectstack/widgets/colorwheel.cpp \
b/src/effectstack/widgets/colorwheel.cpp index 17a0dca..b562ace 100644
--- a/src/effectstack/widgets/colorwheel.cpp
+++ b/src/effectstack/widgets/colorwheel.cpp
@@ -21,7 +21,7 @@
#include "colorwheel.h"
#include <qmath.h>
-ColorWheel::ColorWheel(QString id, QString name, QColor color, QWidget *parent)
+ColorWheel::ColorWheel(const QString &id, const QString &name, const QColor &color, \
QWidget *parent) : QWidget(parent)
, m_id(id)
, m_isMouseDown(false)
diff --git a/src/effectstack/widgets/colorwheel.h \
b/src/effectstack/widgets/colorwheel.h index 8cf8960..25934dc 100644
--- a/src/effectstack/widgets/colorwheel.h
+++ b/src/effectstack/widgets/colorwheel.h
@@ -27,7 +27,7 @@ class ColorWheel : public QWidget
{
Q_OBJECT
public:
- explicit ColorWheel(QString id, QString name, QColor color, QWidget *parent = \
Q_NULLPTR); + explicit ColorWheel(const QString &id, const QString &name, const \
QColor &color, QWidget *parent = Q_NULLPTR);
QSize sizeHint () const Q_DECL_OVERRIDE;
QSize minimumSizeHint () const Q_DECL_OVERRIDE;
diff --git a/src/effectstack/widgets/cornerswidget.cpp \
b/src/effectstack/widgets/cornerswidget.cpp index e2c8905..f580bef 100644
--- a/src/effectstack/widgets/cornerswidget.cpp
+++ b/src/effectstack/widgets/cornerswidget.cpp
@@ -108,7 +108,7 @@ void CornersWidget::slotUpdateItem()
m_monitor->setEffectKeyframe(enable);
}
-void CornersWidget::slotUpdateGeometry(QVariantList points)
+void CornersWidget::slotUpdateGeometry(const QVariantList &points)
{
if (keyframe_list->columnCount() < 8)
return;
diff --git a/src/effectstack/widgets/cornerswidget.h \
b/src/effectstack/widgets/cornerswidget.h index 3360e00..a76fee8 100644
--- a/src/effectstack/widgets/cornerswidget.h
+++ b/src/effectstack/widgets/cornerswidget.h
@@ -62,7 +62,7 @@ private slots:
/** @brief Updates the on-monitor item according to the current timeline \
position. */ void slotUpdateItem();
/** @brief Updates the keyframe editor according to the on-monitor item. */
- void slotUpdateGeometry(QVariantList points);
+ void slotUpdateGeometry(const QVariantList &points);
/** @brief Inserts a keyframe at the current (playback) position (m_pos). */
void slotInsertKeyframe();
diff --git a/src/effectstack/widgets/geometrywidget.cpp \
b/src/effectstack/widgets/geometrywidget.cpp index 84a1ec0..8969e11 100644
--- a/src/effectstack/widgets/geometrywidget.cpp
+++ b/src/effectstack/widgets/geometrywidget.cpp
@@ -715,7 +715,7 @@ void GeometryWidget::slotUpdateGeometryRect(const QRect r)
emit parameterChanged();
}
-void GeometryWidget::slotUpdateCenters(const QVariantList centers)
+void GeometryWidget::slotUpdateCenters(const QVariantList ¢ers)
{
Mlt::GeometryItem item;
int pos = 0;
diff --git a/src/effectstack/widgets/geometrywidget.h \
b/src/effectstack/widgets/geometrywidget.h index fc2668d..cd2ba1e 100644
--- a/src/effectstack/widgets/geometrywidget.h
+++ b/src/effectstack/widgets/geometrywidget.h
@@ -189,7 +189,7 @@ private slots:
/** @brief Show / hide keyframe path in monitor scene. */
void slotShowPath(bool show);
/** @brief Eduit center points for the geometry keyframes. */
- void slotUpdateCenters(const QVariantList centers);
+ void slotUpdateCenters(const QVariantList ¢ers);
signals:
void parameterChanged();
diff --git a/src/effectstack/widgets/selectivecolor.cpp \
b/src/effectstack/widgets/selectivecolor.cpp index 441068a..569b40d 100644
--- a/src/effectstack/widgets/selectivecolor.cpp
+++ b/src/effectstack/widgets/selectivecolor.cpp
@@ -27,7 +27,7 @@ along with this program. If not, see \
<http://www.gnu.org/licenses/>. #include <QDebug>
#include <KLocalizedString>
-SelectiveColor::SelectiveColor(const QDomElement effect, QWidget* parent) :
+SelectiveColor::SelectiveColor(const QDomElement &effect, QWidget* parent) :
QWidget(parent)
{
setupUi(this);
diff --git a/src/effectstack/widgets/selectivecolor.h \
b/src/effectstack/widgets/selectivecolor.h index 1ea1084..275d665 100644
--- a/src/effectstack/widgets/selectivecolor.h
+++ b/src/effectstack/widgets/selectivecolor.h
@@ -43,7 +43,7 @@ public:
* @param text (optional) What the color will be used for
* @param color (optional) initial color
* @param alphaEnabled (optional) Should transparent colors be enabled */
- explicit SelectiveColor(const QDomElement effect, QWidget* parent = Q_NULLPTR);
+ explicit SelectiveColor(const QDomElement &effect, QWidget* parent = Q_NULLPTR);
~SelectiveColor();
void addParam(QDomElement &effect, QString name);
void updateEffect(QDomElement &effect);
diff --git a/src/monitor/glwidget.cpp b/src/monitor/glwidget.cpp
index bd35f33..d704cb9 100644
--- a/src/monitor/glwidget.cpp
+++ b/src/monitor/glwidget.cpp
@@ -1041,7 +1041,7 @@ Mlt::Profile *GLWidget::profile()
return m_monitorProfile;
}
-void GLWidget::resetProfile(MltVideoProfile profile)
+void GLWidget::resetProfile(const MltVideoProfile &profile)
{
if (m_consumer && !m_consumer->is_stopped()) {
m_consumer->stop();
@@ -1405,7 +1405,7 @@ void FrameRenderer::cleanup()
}
}
-void GLWidget::setAudioThumb(int channels, QVariantList audioCache)
+void GLWidget::setAudioThumb(int channels, const QVariantList &audioCache)
{
if (rootObject()) {
QmlAudioThumb *audioThumbDisplay = rootObject()->findChild<QmlAudioThumb \
*>(QStringLiteral("audiothumb"));
diff --git a/src/monitor/glwidget.h b/src/monitor/glwidget.h
index fe932e1..c9e46ad 100644
--- a/src/monitor/glwidget.h
+++ b/src/monitor/glwidget.h
@@ -87,12 +87,12 @@ public:
bool sendFrameForAnalysis;
void updateGamma();
Mlt::Profile *profile();
- void resetProfile(MltVideoProfile profile);
+ void resetProfile(const MltVideoProfile &profile);
void reloadProfile(Mlt::Profile &profile);
void lockMonitor();
void releaseMonitor();
int realTime() const;
- void setAudioThumb(int channels = 0, QVariantList audioCache = \
QList<QVariant>()); + void setAudioThumb(int channels = 0, const QVariantList \
&audioCache = QList<QVariant>()); int droppedFrames() const;
void resetDrops();
diff --git a/src/monitor/monitor.cpp b/src/monitor/monitor.cpp
index 3819ab1..552a3e3 100644
--- a/src/monitor/monitor.cpp
+++ b/src/monitor/monitor.cpp
@@ -383,7 +383,7 @@ void Monitor::slotGetCurrentImage(bool request)
}
}
-void Monitor::slotAddEffect(QDomElement effect)
+void Monitor::slotAddEffect(const QDomElement &effect)
{
if (m_id == Kdenlive::ClipMonitor) {
if (m_controller) emit addMasterEffect(m_controller->clipId(), effect);
@@ -1395,7 +1395,7 @@ void Monitor::setCustomProfile(const QString &profile, const \
Timecode &tc) m_glMonitor->resetProfile(ProfilesDialog::getVideoProfile(profile));
}
-void Monitor::resetProfile(MltVideoProfile profile)
+void Monitor::resetProfile(const MltVideoProfile &profile)
{
m_timePos->updateTimeCode(m_monitorManager->timecode());
if (render == Q_NULLPTR) return;
@@ -1415,7 +1415,7 @@ void Monitor::resetProfile(MltVideoProfile profile)
render->saveSceneList(path, info);
}*/
-const QString Monitor::sceneList(const QString root)
+const QString Monitor::sceneList(const QString &root)
{
if (render == Q_NULLPTR) return QString();
return render->sceneList(root);
@@ -1537,7 +1537,7 @@ void Monitor::slotSeekToKeyFrame()
}
}
-void Monitor::setUpEffectGeometry(QRect r, QVariantList list, QVariantList types)
+void Monitor::setUpEffectGeometry(const QRect &r, const QVariantList &list, const \
QVariantList &types) {
QQuickItem *root = m_glMonitor->rootObject();
if (!root) return;
@@ -1576,6 +1576,7 @@ QVariantList Monitor::effectRoto() const
QVariantList controlPoints = root->property("centerPointsTypes").toList();
// rotoscoping effect needs a list of
QVariantList mix;
+ mix.reserve(points.count() * 3);
for (int i = 0; i < points.count(); i++) {
mix << controlPoints.at(2 * i);
mix << points.at(i);
@@ -1706,7 +1707,7 @@ void Monitor::gpuError()
warningMessage(i18n("Cannot initialize Movit's GLSL manager, please disable \
Movit"), -1); }
-void Monitor::warningMessage(const QString &text, int timeout, QList <QAction*> \
actions) +void Monitor::warningMessage(const QString &text, int timeout, const QList \
<QAction*> &actions) {
m_infoMessage->setMessageType(KMessageWidget::Warning);
m_infoMessage->setText(text);
diff --git a/src/monitor/monitor.h b/src/monitor/monitor.h
index 718e08b..6f97e1f 100644
--- a/src/monitor/monitor.h
+++ b/src/monitor/monitor.h
@@ -89,10 +89,10 @@ public:
~Monitor();
Render *render;
AbstractRender *abstractRender() Q_DECL_OVERRIDE;
- void resetProfile(MltVideoProfile profile);
+ void resetProfile(const MltVideoProfile &profile);
void setCustomProfile(const QString &profile, const Timecode &tc);
void setupMenu(QMenu *goMenu, QMenu *overlayMenu, QAction *playZone, QAction \
*loopZone, QMenu *markerMenu = Q_NULLPTR, QAction *loopClip = \
Q_NULLPTR);
- const QString sceneList(const QString root);
+ const QString sceneList(const QString &root);
const QString activeClipId();
GenTime position();
/** @brief Check current position to show relevant infos in qml view (markers, \
zone in/out, etc). */ @@ -124,7 +124,7 @@ public:
Mlt::Profile *profile();
int getZoneStart();
int getZoneEnd();
- void setUpEffectGeometry(QRect r, QVariantList list = QVariantList(), \
QVariantList types = QVariantList()); + void setUpEffectGeometry(const QRect &r, \
const QVariantList &list = QVariantList(), const QVariantList &types = \
QVariantList()); /** @brief Returns effective display size */
QSize profileSize() const;
QRect effectRect() const;
@@ -259,9 +259,9 @@ private slots:
void slotForceSize(QAction *a);
void slotSeekToKeyFrame();
/** @brief Display a non blocking error message to user **/
- void warningMessage(const QString &text, int timeout = 5000, QList <QAction*> \
actions = QList <QAction*>()); + void warningMessage(const QString &text, int \
timeout = 5000, const QList<QAction *> &actions = QList <QAction*>()); void \
slotLockMonitor(bool lock);
- void slotAddEffect(QDomElement effect);
+ void slotAddEffect(const QDomElement &effect);
void slotSwitchPlay();
void slotEditInlineMarker();
/** @brief Pass keypress event to mainwindow */
diff --git a/src/monitor/monitormanager.cpp b/src/monitor/monitormanager.cpp
index a169f60..ccd6216 100644
--- a/src/monitor/monitormanager.cpp
+++ b/src/monitor/monitormanager.cpp
@@ -56,7 +56,7 @@ void MonitorManager::setDocument(KdenliveDoc *doc)
m_document = doc;
}
-QAction *MonitorManager::getAction(QString name)
+QAction *MonitorManager::getAction(const QString &name)
{
return pCore->window()->action(name.toLatin1());
}
diff --git a/src/monitor/monitormanager.h b/src/monitor/monitormanager.h
index 0755d24..5c9ec4a 100644
--- a/src/monitor/monitormanager.h
+++ b/src/monitor/monitormanager.h
@@ -63,7 +63,7 @@ public:
BinController *binController();
Mlt::Profile *profile();
/** @brief Return a mainwindow action from its id name. */
- QAction *getAction(QString name);
+ QAction *getAction(const QString &name);
Monitor *clipMonitor();
Monitor *projectMonitor();
void lockMonitor(Kdenlive::MonitorId name, bool);
diff --git a/src/project/clipmanager.cpp b/src/project/clipmanager.cpp
index 7a1b232..808804d 100644
--- a/src/project/clipmanager.cpp
+++ b/src/project/clipmanager.cpp
@@ -223,7 +223,7 @@ void ClipManager::deleteProjectItems(const QStringList &clipIds, \
const QStringLi }
}
-void ClipManager::doDeleteClips(QStringList clipIds, QStringList folderIds, \
QStringList subClipIds, QUndoCommand *deleteCommand, bool execute) +void \
ClipManager::doDeleteClips(const QStringList &clipIds, const QStringList &folderIds, \
const QStringList &subClipIds, QUndoCommand *deleteCommand, bool execute) {
for (int i = 0; i < clipIds.size(); ++i) {
QString xml = pCore->binController()->xmlFromId(clipIds.at(i));
diff --git a/src/project/clipmanager.h b/src/project/clipmanager.h
index b48bc65..f16decf 100644
--- a/src/project/clipmanager.h
+++ b/src/project/clipmanager.h
@@ -70,7 +70,7 @@ Q_OBJECT public:
virtual ~ ClipManager();
void slotAddTextTemplateClip(const QString &titleName, const QUrl &path, const \
QString &group, const QString &groupId);
- void doDeleteClips(QStringList clipIds, QStringList folderIds, QStringList \
subClipIds, QUndoCommand *deleteCommand, bool execute); + void doDeleteClips(const \
QStringList &clipIds, const QStringList &folderIds, const QStringList &subClipIds, \
QUndoCommand *deleteCommand, bool execute); int lastClipId() const;
/** @brief Prepare deletion of clips and folders from the Bin. */
void deleteProjectItems(const QStringList &clipIds, const QStringList \
&folderIds, const QStringList &subClipIds, QUndoCommand \
*deleteCommand = Q_NULLPTR);
diff --git a/src/project/jobs/cutclipjob.cpp b/src/project/jobs/cutclipjob.cpp
index 400004c..33dea3e 100644
--- a/src/project/jobs/cutclipjob.cpp
+++ b/src/project/jobs/cutclipjob.cpp
@@ -220,7 +220,7 @@ bool CutClipJob::isExclusive()
}
// static
-QList <ProjectClip *> CutClipJob::filterClips(QList <ProjectClip *>clips, const \
QStringList ¶ms) +QList <ProjectClip *> CutClipJob::filterClips(const QList \
<ProjectClip *> &clips, const QStringList ¶ms) {
QString condition;
if (params.count() > 3) {
diff --git a/src/project/jobs/cutclipjob.h b/src/project/jobs/cutclipjob.h
index fa31af5..3b9da66 100644
--- a/src/project/jobs/cutclipjob.h
+++ b/src/project/jobs/cutclipjob.h
@@ -54,7 +54,7 @@ public:
static QHash <ProjectClip *, AbstractClipJob *> prepareTranscodeJob(double fps, \
const QList<ProjectClip *> &ids, const QStringList ¶meters);
static QHash <ProjectClip *, AbstractClipJob *> prepareCutClipJob(double fps, \
double originalFps, ProjectClip *clip);
static QHash <ProjectClip *, AbstractClipJob *> prepareAnalyseJob(double fps, \
const QList <ProjectClip*> &clips, const QStringList ¶meters);
- static QList <ProjectClip *> filterClips(QList <ProjectClip *>clips, const \
QStringList ¶ms); + static QList <ProjectClip *> filterClips(const \
QList<ProjectClip *> &clips, const QStringList ¶ms);
private:
QString m_dest;
diff --git a/src/renderer.cpp b/src/renderer.cpp
index 939168f..83bb5cf 100644
--- a/src/renderer.cpp
+++ b/src/renderer.cpp
@@ -554,7 +554,7 @@ void Render::checkMaxThreads()
}
-const QString Render::sceneList(const QString root)
+const QString Render::sceneList(const QString &root)
{
QString playlist;
qDebug()<<" * * *Setting document xml root: "<<root;
diff --git a/src/renderer.h b/src/renderer.h
index 30d3f5d..5d7b799 100644
--- a/src/renderer.h
+++ b/src/renderer.h
@@ -131,7 +131,7 @@ class Render: public AbstractRender
/** @brief Get the current MLT producer playlist.
* @return A string describing the playlist */
- const QString sceneList(const QString root);
+ const QString sceneList(const QString &root);
/** @brief Tells the renderer to play the scene at the specified speed,
* @param speed speed to play the scene to
diff --git a/src/timeline/clipitem.cpp b/src/timeline/clipitem.cpp
index 64c1bbc..50b9924 100644
--- a/src/timeline/clipitem.cpp
+++ b/src/timeline/clipitem.cpp
@@ -1826,7 +1826,7 @@ QMap<int, QDomElement> ClipItem::adjustEffectsToDuration(const \
ItemInfo &oldInfo }
-bool ClipItem::updateAnimatedKeyframes(int ix, QDomElement parameter, const ItemInfo \
&oldInfo) +bool ClipItem::updateAnimatedKeyframes(int ix, const QDomElement \
¶meter, const ItemInfo &oldInfo) {
int in = cropStart().frames(m_fps);
int out = (cropStart() + cropDuration()).frames(m_fps) - 1;
@@ -1977,7 +1977,7 @@ void ClipItem::updateState(const QString &id, int aIndex, int \
vIndex, PlaylistSt }
}
-void ClipItem::slotUpdateThumb(QImage img)
+void ClipItem::slotUpdateThumb(const QImage &img)
{
m_startPix = QPixmap::fromImage(img);
update();
diff --git a/src/timeline/clipitem.h b/src/timeline/clipitem.h
index 547da9b..41117b1 100644
--- a/src/timeline/clipitem.h
+++ b/src/timeline/clipitem.h
@@ -166,7 +166,7 @@ public:
QPixmap endThumb() const;
void setState(PlaylistState::ClipState state);
void updateState(const QString &id, int aIndex, int vIndex, \
PlaylistState::ClipState originalState);
- bool updateAnimatedKeyframes(int ix, QDomElement parameter, const ItemInfo \
&oldInfo); + bool updateAnimatedKeyframes(int ix, const QDomElement ¶meter, \
const ItemInfo &oldInfo);
bool updateNormalKeyframes(QDomElement parameter, const ItemInfo &oldInfo);
/** @brief Adjusts effects after a clip duration change. */
@@ -247,7 +247,7 @@ private slots:
void slotSetEndThumb(const QImage &img);
void slotThumbReady(int frame, const QImage &img);
/** @brief For fixed thumbnail clip (image / titles), update thumb to reflect \
bin thumbnail. */
- void slotUpdateThumb(QImage);
+ void slotUpdateThumb(const QImage &);
/** @brief Something changed a detail in clip (thumbs, markers,...), repaint. */
void slotRefreshClip();
diff --git a/src/timeline/customtrackview.cpp b/src/timeline/customtrackview.cpp
index 575c343..389c5c7 100644
--- a/src/timeline/customtrackview.cpp
+++ b/src/timeline/customtrackview.cpp
@@ -1922,7 +1922,7 @@ void CustomTrackView::slotRefreshEffects(ClipItem *clip)
monitorRefresh(clip->info());
}
-void CustomTrackView::addEffect(int track, GenTime pos, QDomElement effect)
+void CustomTrackView::addEffect(int track, GenTime pos, const QDomElement &effect)
{
if (pos < GenTime()) {
// Add track effect
diff --git a/src/timeline/customtrackview.h b/src/timeline/customtrackview.h
index 8036551..60116f3 100644
--- a/src/timeline/customtrackview.h
+++ b/src/timeline/customtrackview.h
@@ -90,7 +90,7 @@ public:
/** @brief Add effect to a clip or selection */
void slotAddEffect(const QDomElement &effect, const GenTime &pos, int track);
void slotAddGroupEffect(const QDomElement &effect, AbstractGroupItem *group, \
AbstractClipItem *dropTarget = Q_NULLPTR);
- void addEffect(int track, GenTime pos, QDomElement effect);
+ void addEffect(int track, GenTime pos, const QDomElement &effect);
void deleteEffect(int track, const GenTime &pos, const QDomElement &effect);
void updateEffect(int track, GenTime pos, QDomElement insertedEffect, bool \
refreshEffectStack = false, bool replaceEffect = false, bool refreshMonitor = true); \
/** @brief Enable / disable a list of effects */
diff --git a/src/timeline/effectmanager.cpp b/src/timeline/effectmanager.cpp
index 59bde0b..fcb4565 100644
--- a/src/timeline/effectmanager.cpp
+++ b/src/timeline/effectmanager.cpp
@@ -68,7 +68,7 @@ void EffectManager::setProducer(Mlt::Service& producer)
}
}*/
-bool EffectManager::addEffect(EffectsParameterList params, int duration)
+bool EffectManager::addEffect(const EffectsParameterList ¶ms, int duration)
{
bool updateIndex = false;
const int filter_ix = params.paramValue(QStringLiteral("kdenlive_ix")).toInt();
diff --git a/src/timeline/effectmanager.h b/src/timeline/effectmanager.h
index 4527b78..8f5e129 100644
--- a/src/timeline/effectmanager.h
+++ b/src/timeline/effectmanager.h
@@ -42,7 +42,7 @@ public:
EffectManager& operator=(EffectManager& other);
Mlt::Service & producer();
void setProducer(Mlt::Service& producer);
- bool addEffect(EffectsParameterList params, int duration);
+ bool addEffect(const EffectsParameterList ¶ms, int duration);
bool doAddFilter(EffectsParameterList params, int duration);
bool editEffect(EffectsParameterList params, int duration, bool replaceEffect);
bool removeEffect(int effectIndex, bool updateIndex);
diff --git a/src/timeline/keyframeview.cpp b/src/timeline/keyframeview.cpp
index 095afd0..bfddf4a 100644
--- a/src/timeline/keyframeview.cpp
+++ b/src/timeline/keyframeview.cpp
@@ -522,7 +522,7 @@ double KeyframeView::editedKeyFrameValue()
return m_keyProperties.anim_get_double(m_inTimeline.toUtf8().constData(), \
activeKeyframe, duration - m_offset); }
-void KeyframeView::updateKeyFramePos(QRectF br, int frame, const double y)
+void KeyframeView::updateKeyFramePos(const QRectF &br, int frame, const double y)
{
if (!m_keyAnim.is_key(activeKeyframe)) {
return;
diff --git a/src/timeline/keyframeview.h b/src/timeline/keyframeview.h
index ca1d69c..16a288e 100644
--- a/src/timeline/keyframeview.h
+++ b/src/timeline/keyframeview.h
@@ -67,7 +67,7 @@ public:
* @param br the bounding rect for effect drawing
* @param frame new Position
* @param y new Value */
- void updateKeyFramePos(QRectF br, int frame, const double y);
+ void updateKeyFramePos(const QRectF &br, int frame, const double y);
double getKeyFrameClipHeight(const QRectF &br, const double y);
/** @brief Returns the number of keyframes the selected effect has, -1 if none. \
*/ int keyframesCount();
diff --git a/src/timeline/managers/previewmanager.cpp \
b/src/timeline/managers/previewmanager.cpp index 1e82644..3ea9459 100644
--- a/src/timeline/managers/previewmanager.cpp
+++ b/src/timeline/managers/previewmanager.cpp
@@ -111,7 +111,7 @@ bool PreviewManager::buildPreviewTrack()
return true;
}
-void PreviewManager::loadChunks(QStringList previewChunks, QStringList dirtyChunks, \
QDateTime documentDate) +void PreviewManager::loadChunks(const QStringList \
&previewChunks, QStringList dirtyChunks, const QDateTime &documentDate) {
foreach (const QString frame, previewChunks) {
const QString fileName = \
m_cacheDir.absoluteFilePath(QStringLiteral("%1.%2").arg(frame).arg(m_extension));
diff --git a/src/timeline/managers/previewmanager.h \
b/src/timeline/managers/previewmanager.h index 2509e63..acc413f 100644
--- a/src/timeline/managers/previewmanager.h
+++ b/src/timeline/managers/previewmanager.h
@@ -77,7 +77,7 @@ public:
/** @brief: Returns directory currently used to store the preview files. */
const QDir getCacheDir() const;
/** @brief: Load existing ruler chunks. */
- void loadChunks(QStringList previewChunks, QStringList dirtyChunks, QDateTime \
documentDate); + void loadChunks(const QStringList &previewChunks, QStringList \
dirtyChunks, const QDateTime &documentDate);
private:
KdenliveDoc *m_doc;
diff --git a/src/timeline/managers/trimmanager.cpp \
b/src/timeline/managers/trimmanager.cpp index ca5f39d..6b6554b 100644
--- a/src/timeline/managers/trimmanager.cpp
+++ b/src/timeline/managers/trimmanager.cpp
@@ -69,7 +69,7 @@ void TrimManager::mouseRelease(QMouseEvent *, GenTime)
endTrim();
}
-bool TrimManager::enterTrimMode(ItemInfo info, bool trimStart)
+bool TrimManager::enterTrimMode(const ItemInfo &info, bool trimStart)
{
m_view->loadMonitorScene(MonitorSceneRipple, true);
m_view->setQmlProperty(QStringLiteral("trimmode"), (int) m_trimMode);
@@ -212,7 +212,7 @@ TrimMode TrimManager::trimMode() const
return m_trimMode;
}
-void TrimManager::setTrimMode(TrimMode mode, ItemInfo info, bool fromStart)
+void TrimManager::setTrimMode(TrimMode mode, const ItemInfo &info, bool fromStart)
{
m_trimMode = mode;
if (trimChanged && mode != NormalTrim) {
diff --git a/src/timeline/managers/trimmanager.h \
b/src/timeline/managers/trimmanager.h index c152e56..55b9b09 100644
--- a/src/timeline/managers/trimmanager.h
+++ b/src/timeline/managers/trimmanager.h
@@ -43,9 +43,9 @@ public:
bool mousePress(QMouseEvent *event, const ItemInfo &info = ItemInfo(), const \
QList<QGraphicsItem *> &list = QList<QGraphicsItem *>()) \
Q_DECL_OVERRIDE;
bool mouseMove(QMouseEvent *event, int pos, int track = -1) Q_DECL_OVERRIDE;
void mouseRelease(QMouseEvent *event, GenTime pos = GenTime()) Q_DECL_OVERRIDE;
- bool enterTrimMode(ItemInfo info, bool trimStart);
+ bool enterTrimMode(const ItemInfo &info, bool trimStart);
void moveRoll(bool forward, int pos = -1);
- void setTrimMode(TrimMode mode, ItemInfo info = ItemInfo(), bool fromStart = \
true); + void setTrimMode(TrimMode mode, const ItemInfo &info = ItemInfo(), bool \
fromStart = true); TrimMode trimMode() const;
void initRipple(Mlt::Playlist *playlist, int pos, Render *renderer);
diff --git a/src/timeline/timeline.cpp b/src/timeline/timeline.cpp
index 349ef78..db7e4ad 100644
--- a/src/timeline/timeline.cpp
+++ b/src/timeline/timeline.cpp
@@ -654,7 +654,7 @@ bool Timeline::isLastClip(const ItemInfo &info)
return tk->isLastClip(info.endPos.seconds());
}
-void Timeline::setTrackInfo(int ix, TrackInfo info)
+void Timeline::setTrackInfo(int ix, const TrackInfo &info)
{
if (ix < 0 || ix > m_tracks.count()) {
qWarning() << "Set Track effect outisde of range";
@@ -934,7 +934,7 @@ void Timeline::reloadTrack(int ix, int start, int end)
loadTrack(ix, 0, pl, startIndex, endIndex, false);
}
-void Timeline::reloadTrack(ItemInfo info, bool includeLastFrame)
+void Timeline::reloadTrack(const ItemInfo &info, bool includeLastFrame)
{
// Get playlist
if (!info.isValid())
@@ -1852,7 +1852,7 @@ void Timeline::stopPreviewRender()
m_timelinePreview->abortRendering();
}
-void Timeline::invalidateRange(ItemInfo info)
+void Timeline::invalidateRange(const ItemInfo &info)
{
if (!m_timelinePreview)
return;
diff --git a/src/timeline/timeline.h b/src/timeline/timeline.h
index 7c15ac3..bcf6b5b 100644
--- a/src/timeline/timeline.h
+++ b/src/timeline/timeline.h
@@ -120,7 +120,7 @@ public:
* @param ix The track number in MLT's coordinates (0 = black track, 1 = bottom \
audio, etc)
* deprecated use string version with track name instead */
TrackInfo getTrackInfo(int ix);
- void setTrackInfo(int trackIndex, TrackInfo info);
+ void setTrackInfo(int trackIndex, const TrackInfo &info);
QList <TrackInfo> getTracksInfo();
QStringList getTrackNames();
void addTrackEffect(int trackIndex, QDomElement effect, bool addToPlaylist = \
true); @@ -175,7 +175,7 @@ public:
/** @brief Returns the document properties with some added values from timeline. \
*/ QMap <QString, QString> documentProperties();
void reloadTrack(int ix, int start = 0, int end = -1);
- void reloadTrack(ItemInfo info, bool includeLastFrame);
+ void reloadTrack(const ItemInfo &info, bool includeLastFrame);
/** @brief Add or remove current timeline zone to preview render zone. */
void addPreviewRange(bool add);
/** @brief Resets all preview render zones. */
@@ -204,7 +204,7 @@ public slots:
/** @brief Stop rendering preview. */
void stopPreviewRender();
/** @brief Invalidate a preview rendering range. */
- void invalidateRange(ItemInfo info = ItemInfo());
+ void invalidateRange(const ItemInfo &info = ItemInfo());
private:
Mlt::Tractor *m_tractor;
diff --git a/src/timeline/timelinecommands.cpp b/src/timeline/timelinecommands.cpp
index 4ee8f7a..cf43d47 100644
--- a/src/timeline/timelinecommands.cpp
+++ b/src/timeline/timelinecommands.cpp
@@ -165,7 +165,7 @@ void AddTransitionCommand::redo()
m_doIt = true;
}
-ChangeClipTypeCommand::ChangeClipTypeCommand(CustomTrackView *view, ItemInfo info, \
PlaylistState::ClipState state, PlaylistState::ClipState originalState, QUndoCommand \
* parent) : +ChangeClipTypeCommand::ChangeClipTypeCommand(CustomTrackView *view, \
const ItemInfo &info, PlaylistState::ClipState state, PlaylistState::ClipState \
originalState, QUndoCommand * parent) : QUndoCommand(parent),
m_view(view),
m_info(info),
diff --git a/src/timeline/timelinecommands.h b/src/timeline/timelinecommands.h
index be3ec70..a510623 100644
--- a/src/timeline/timelinecommands.h
+++ b/src/timeline/timelinecommands.h
@@ -107,7 +107,7 @@ private:
class ChangeClipTypeCommand : public QUndoCommand
{
public:
- ChangeClipTypeCommand(CustomTrackView *view, ItemInfo info, \
PlaylistState::ClipState state, PlaylistState::ClipState originalState, QUndoCommand \
* parent = Q_NULLPTR); + ChangeClipTypeCommand(CustomTrackView *view, const \
ItemInfo &info, PlaylistState::ClipState state, PlaylistState::ClipState \
originalState, QUndoCommand * parent = Q_NULLPTR); void undo() Q_DECL_OVERRIDE;
void redo() Q_DECL_OVERRIDE;
private:
diff --git a/src/timeline/transitionhandler.cpp b/src/timeline/transitionhandler.cpp
index 1324c0f..a761484 100644
--- a/src/timeline/transitionhandler.cpp
+++ b/src/timeline/transitionhandler.cpp
@@ -63,7 +63,7 @@ bool TransitionHandler::addTransition(QString tag, int a_track, int \
b_track, Gen return true;
}
-void TransitionHandler::initTransition(QDomElement xml)
+void TransitionHandler::initTransition(const QDomElement &xml)
{
QMap<QString, QString> params = getTransitionParamsFromXml(xml);
QMapIterator<QString, QString> i(params);
@@ -303,7 +303,7 @@ void TransitionHandler::updateTransitionParams(QString type, int \
a_track, int b_ }
-bool TransitionHandler::deleteTransition(QString tag, int /*a_track*/, int b_track, \
GenTime in, GenTime out, QDomElement /*xml*/, bool /*do_refresh*/) +bool \
TransitionHandler::deleteTransition(const QString &tag, int /*a_track*/, int b_track, \
GenTime in, GenTime out, const QDomElement &/*xml*/, bool /*do_refresh*/) {
QScopedPointer<Mlt::Field> field(m_tractor->field());
field->lock();
diff --git a/src/timeline/transitionhandler.h b/src/timeline/transitionhandler.h
index cefcbe9..c95f23e 100644
--- a/src/timeline/transitionhandler.h
+++ b/src/timeline/transitionhandler.h
@@ -44,7 +44,7 @@ public:
void cloneProperties(Mlt::Properties &dest, Mlt::Properties &source);
void updateTransition(const QString &oldTag, const QString &tag, int a_track, \
int b_track, GenTime in, GenTime out, const QDomElement &xml, bool \
force = false);
void updateTransitionParams(QString type, int a_track, int b_track, GenTime in, \
GenTime out, QDomElement xml);
- bool deleteTransition(QString tag, int a_track, int b_track, GenTime in, GenTime \
out, QDomElement xml, bool refresh = true); + bool deleteTransition(const QString \
&tag, int a_track, int b_track, GenTime in, GenTime out, const QDomElement &xml, bool \
refresh = true); void deleteTrackTransitions(int ix);
bool moveTransition(QString type, int startTrack, int newTrack, int \
newTransitionTrack, GenTime oldIn, GenTime oldOut, GenTime newIn, \
GenTime newOut);
QList <TransitionInfo> mltInsertTrack(int ix, const QString &name, bool \
videoTrack); @@ -60,7 +60,7 @@ public:
/** @brief Returns the matching composite transition depending on the current \
settings. */ static const QString compositeTransition();
/** @brief Initialize transition settings. */
- void initTransition(QDomElement xml);
+ void initTransition(const QDomElement &xml);
private:
Mlt::Tractor *m_tractor;
diff --git a/src/titler/gradientwidget.cpp b/src/titler/gradientwidget.cpp
index 60c6dcc..2a1b0a1 100644
--- a/src/titler/gradientwidget.cpp
+++ b/src/titler/gradientwidget.cpp
@@ -31,7 +31,7 @@ along with this program. If not, see \
<http://www.gnu.org/licenses/>.
#include "utils/KoIconUtils.h"
-GradientWidget::GradientWidget(QMap <QString, QString> gradients, int ix, QWidget \
*parent) : +GradientWidget::GradientWidget(const QMap <QString, QString> &gradients, \
int ix, QWidget *parent) : QDialog(parent),
Ui::GradientEdit_UI()
{
diff --git a/src/titler/gradientwidget.h b/src/titler/gradientwidget.h
index 9e375e1..c0a8be5 100644
--- a/src/titler/gradientwidget.h
+++ b/src/titler/gradientwidget.h
@@ -42,7 +42,7 @@ public:
* @param projectPath default path to save to or load from title documents
* @param render project renderer
* @param parent (optional) parent widget */
- explicit GradientWidget(QMap <QString, QString> gradients = QMap<QString, \
QString>(), int ix = 0, QWidget *parent = Q_NULLPTR); + explicit \
GradientWidget(const QMap<QString, QString> &gradients = QMap<QString, QString>(), \
int ix = 0, QWidget *parent = Q_NULLPTR); void resizeEvent(QResizeEvent* event) \
Q_DECL_OVERRIDE; QString gradientToString() const;
static QLinearGradient gradientFromString(const QString &str, int width, int \
height);
diff --git a/src/titler/titlewidget.cpp b/src/titler/titlewidget.cpp
index cc6a11c..e6b22af 100644
--- a/src/titler/titlewidget.cpp
+++ b/src/titler/titlewidget.cpp
@@ -847,7 +847,7 @@ void TitleWidget::displayBackgroundFrame()
}
}
-void TitleWidget::slotGotBackground(QImage img)
+void TitleWidget::slotGotBackground(const QImage &img)
{
QRectF r = m_frameBorder->sceneBoundingRect();
m_frameImage->setPixmap(QPixmap::fromImage(img.scaled(r.width() / 2, r.height() \
/ 2)));
diff --git a/src/titler/titlewidget.h b/src/titler/titlewidget.h
index f2a7b05..e7b83d5 100644
--- a/src/titler/titlewidget.h
+++ b/src/titler/titlewidget.h
@@ -232,7 +232,7 @@ public slots:
void saveTitle(QUrl url = QUrl());
/** Load a title from a title file */
void loadTitle(QUrl url = QUrl());
- void slotGotBackground(QImage img);
+ void slotGotBackground(const QImage &img);
private slots:
diff --git a/src/utils/progressbutton.cpp b/src/utils/progressbutton.cpp
index e2156ef..a65467a 100644
--- a/src/utils/progressbutton.cpp
+++ b/src/utils/progressbutton.cpp
@@ -25,7 +25,7 @@ along with this program. If not, see \
<http://www.gnu.org/licenses/>. #include <QAction>
#include <QPainter>
-ProgressButton::ProgressButton(const QString text, double max, QWidget *parent) : \
QToolButton(parent) +ProgressButton::ProgressButton(const QString &text, double max, \
QWidget *parent) : QToolButton(parent) , m_defaultAction(Q_NULLPTR)
, m_max(max)
{
diff --git a/src/utils/progressbutton.h b/src/utils/progressbutton.h
index 1ba43a8..5871893 100644
--- a/src/utils/progressbutton.h
+++ b/src/utils/progressbutton.h
@@ -39,7 +39,7 @@ class ProgressButton: public QToolButton
Q_PROPERTY(int progress READ progress WRITE setProgress)
Q_OBJECT
public:
- explicit ProgressButton(const QString text, double max = 100, QWidget *parent = \
Q_NULLPTR); + explicit ProgressButton(const QString &text, double max = 100, \
QWidget *parent = Q_NULLPTR); ~ProgressButton();
int progress() const;
void setProgress(int);
diff --git a/src/utils/resourcewidget.cpp b/src/utils/resourcewidget.cpp
index 0226fb6..f5d8ec5 100644
--- a/src/utils/resourcewidget.cpp
+++ b/src/utils/resourcewidget.cpp
@@ -432,7 +432,7 @@ void ResourceWidget::slotSaveItem(const QString &originalUrl)
* when user chooses to use HQ preview file from freesound
* Starts a file copy job to download the file. When file finishes dowloading \
slotGotFile will be called
*/
-void ResourceWidget::DoFileDownload(QUrl srcUrl, QUrl saveUrl)
+void ResourceWidget::DoFileDownload(const QUrl &srcUrl, const QUrl &saveUrl)
{
KIO::FileCopyJob * getJob = KIO::file_copy(srcUrl, saveUrl, -1, KIO::Overwrite);
KFileItem info(srcUrl);
@@ -753,7 +753,7 @@ void ResourceWidget::slotFreesoundAccessDenied()
* and starts the download of the requested file. \
ResourceWidget::DownloadRequestFinished will be
* notified when that job finishes
*/
-void ResourceWidget::slotAccessTokenReceived(QString sAccessToken)
+void ResourceWidget::slotAccessTokenReceived(const QString &sAccessToken)
{
//qDebug() << "slotAccessTokenReceived: " <<sAccessToken;
if (sAccessToken !=QLatin1String(""))
@@ -791,7 +791,7 @@ void ResourceWidget::slotAccessTokenReceived(QString \
sAccessToken)
* Prompts user to choose a file name and path as to where to save a file.
* Returns a QString of the path and file name or empty string if user cancels
*/
-QString ResourceWidget::GetSaveFileNameAndPathS(QString path,QString ext)
+QString ResourceWidget::GetSaveFileNameAndPathS(const QString &path,const QString \
&ext) {
QString saveUrlstring = QFileDialog::getSaveFileName(this, QString(), path, \
ext); if ( saveUrlstring.isEmpty() )
diff --git a/src/utils/resourcewidget.h b/src/utils/resourcewidget.h
index 46f24f5..da9d938 100644
--- a/src/utils/resourcewidget.h
+++ b/src/utils/resourcewidget.h
@@ -83,7 +83,7 @@ private slots:
void slotFreesoundAccessDenied();
void slotReadyRead();
void DownloadRequestFinished(QNetworkReply* reply);
- void slotAccessTokenReceived(QString sAccessToken);
+ void slotAccessTokenReceived(const QString &sAccessToken);
void slotFreesoundUseHQPreview();
void slotFreesoundCanceled();
void slotSearchFinished();
@@ -98,7 +98,7 @@ private:
void loadConfig();
void saveConfig();
void parseLicense(const QString &);
- QString GetSaveFileNameAndPathS(QString path,QString ext);
+ QString GetSaveFileNameAndPathS(const QString &path, const QString &ext);
QString m_folder;
QString mSaveLocation;
AbstractService *m_currentService;
@@ -110,7 +110,7 @@ private:
QString m_meta;
QMovie *m_movie;
void updateLayout();
- void DoFileDownload(QUrl srcUrl, QUrl saveUrl);
+ void DoFileDownload(const QUrl &srcUrl, const QUrl &saveUrl);
signals:
void addClip(const QUrl&);
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic