[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kwin/Plasma/5.8] kcmkwin/kwindecoration/qml: Align configure button consistently across delegates
From:       David Edmundson <kde () davidedmundson ! co ! uk>
Date:       2016-11-28 9:25:24
Message-ID: E1cBIBg-0008Ex-LC () code ! kde ! org
[Download RAW message or body]

Git commit d0e0f6c88cdd032d3bdb9dc7b0c85902fb3d859a by David Edmundson.
Committed on 28/11/2016 at 09:24.
Pushed by davidedmundson into branch 'Plasma/5.8'.

Align configure button consistently across delegates

Summary:
Currently the configure button is aligned to the win decoration in the
background. This is bound to 40 - the inactive decorations shadow.

This means the configure button ends up in different places across each
item,
looking a bit weird and potentially not even on top of the right
delegate.

This patch aligns the configure button relative to the overall delegate
so that it's in the same place on every item

Test Plan: Looked at KCM

Reviewers: #plasma

Subscribers: plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D3526

BUG: 372685

M  +3    -2    kcmkwin/kwindecoration/qml/Previews.qml

https://commits.kde.org/kwin/d0e0f6c88cdd032d3bdb9dc7b0c85902fb3d859a

diff --git a/kcmkwin/kwindecoration/qml/Previews.qml b/kcmkwin/kwindecorati=
on/qml/Previews.qml
index fe4c5b3..be8036c 100644
--- a/kcmkwin/kwindecoration/qml/Previews.qml
+++ b/kcmkwin/kwindecoration/qml/Previews.qml
@@ -107,8 +107,9 @@ ScrollView {
                     Button {
                         id: configureButton
                         anchors {
-                            left: inactivePreview.left
-                            bottom: inactivePreview.bottom
+                            left: parent.left
+                            bottom: parent.bottom
+                            margins: 20
                         }
                         enabled: model["configureable"]
                         iconName: "configure"
[prev in list] [next in list] [prev in thread] [next in thread]