[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kopete/Applications/16.12] plugins/otr: Fix crash after OTR plugin generates key
From:       Pali_Rohár <pali.rohar () gmail ! com>
Date:       2016-11-27 15:58:02
Message-ID: E1cB1q6-0005iy-34 () code ! kde ! org
[Download RAW message or body]

Git commit 15579ddcf34ad04bf190a189b670f62c3796c057 by Pali Rohár.
Committed on 27/11/2016 at 15:55.
Pushed by pali into branch 'Applications/16.12'.

Fix crash after OTR plugin generates key

Function OtrlChatInterface::replayStoredMessages() had wrong logic to check
if there is still some postponed message waiting for processing.

BUG: 349596
FIXED-IN: 16.12

M  +1    -1    plugins/otr/otrlchatinterface.cpp

https://commits.kde.org/kopete/15579ddcf34ad04bf190a189b670f62c3796c057

diff --git a/plugins/otr/otrlchatinterface.cpp b/plugins/otr/otrlchatinterface.cpp
index 0c73323..6b76520 100644
--- a/plugins/otr/otrlchatinterface.cpp
+++ b/plugins/otr/otrlchatinterface.cpp
@@ -932,7 +932,7 @@ void OtrlChatInterface::otrlMessagePoll()
 
 void OtrlChatInterface::replayStoredMessages()
 {
-    while (m_storedMessages.isEmpty()) {
+    while (!m_storedMessages.isEmpty()) {
         Kopete::Message msg = m_storedMessages.takeFirst();
         msg.manager()->appendMessage(msg);
     }
[prev in list] [next in list] [prev in thread] [next in thread]