[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kbibtex] src/gui/element: Fixing minor issue with fix for bug 371593
From:       Thomas Fischer <fischer () unix-ag ! uni-kl ! de>
Date:       2016-11-26 21:53:09
Message-ID: E1cAkuD-0006O8-Rp () code ! kde ! org
[Download RAW message or body]

Git commit fdc79bb9eb0f224e9e0149f560460160f94d78c3 by Thomas Fischer, on behalf of Juergen Spitzmueller.
Committed on 26/11/2016 at 21:37.
Pushed by thomasfischer into branch 'master'.

Fixing minor issue with fix for bug 371593

There was a small glitch in commit 4e117aa38b3 that was meant
to fix bug 371593: Customized text was set too early and then
overwritten. This commit fixes the problem.

Signed-off-by: Thomas Fischer <fischer@unix-ag.uni-kl.de>

M  +4    -1    src/gui/element/elementwidgets.cpp

https://commits.kde.org/kbibtex/fdc79bb9eb0f224e9e0149f560460160f94d78c3

diff --git a/src/gui/element/elementwidgets.cpp b/src/gui/element/elementwidgets.cpp
index 8d4990e..89094f5 100644
--- a/src/gui/element/elementwidgets.cpp
+++ b/src/gui/element/elementwidgets.cpp
@@ -373,7 +373,6 @@ bool ReferenceWidget::reset(QSharedPointer<const Element> element)
         buttonSuggestId->setEnabled(!isReadOnly);
         const BibTeXEntries *be = BibTeXEntries::self();
         QString type = be->format(entry->type(), KBibTeX::cUpperCamelCase);
-        entryType->lineEdit()->setText(type);
         int index = entryType->findData(type);
         if (index == -1) {
             const QString typeLower(type.toLower());
@@ -384,6 +383,10 @@ bool ReferenceWidget::reset(QSharedPointer<const Element> element)
                 }
         }
         entryType->setCurrentIndex(index);
+        if (index == -1) {
+             /// A customized value not known to KBibTeX
+             entryType->lineEdit()->setText(type);
+        }
 
         entryId->setText(entry->id());
         /// New entries have no values. Use this fact

[prev in list] [next in list] [prev in thread] [next in thread]