[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [calligra] sheets/commands: Sheets: Comment out assert in Special paste cmd as it hits most times
From:       Dag Andersen <danders () get2net ! dk>
Date:       2016-11-25 12:24:55
Message-ID: E1cAFYl-00073m-Qk () code ! kde ! org
[Download RAW message or body]

Git commit cac72ab2f8264684e044ce2a81344005508f2e2e by Dag Andersen.
Committed on 25/11/2016 at 12:20.
Pushed by danders into branch 'master'.

Sheets: Comment out assert in Special paste cmd as it hits most times

There is probably a wrong assumtion/bug somewhere, but code seems to work ok
so just comment out the assert for now.

CCMAIL: mecirt@gmail.com

M  +6    -1    sheets/commands/PasteCommand.cpp

https://commits.kde.org/calligra/cac72ab2f8264684e044ce2a81344005508f2e2e

diff --git a/sheets/commands/PasteCommand.cpp b/sheets/commands/PasteCommand.cpp
index c7b627c..2b7864d 100644
--- a/sheets/commands/PasteCommand.cpp
+++ b/sheets/commands/PasteCommand.cpp
@@ -324,7 +324,12 @@ bool PasteCommand::processXmlData(Element *element, KoXmlDocument *data)
         } else {
             // Should not happen.
             // ShiftCells should only be set, if the data contains columns/rows.
-            Q_ASSERT(false);
+            // FIXME:
+            // Commenting out this assert because:
+            // We almost always get here (except when a whole row is selected)
+            // The comment above indicates that this is not the way it was meant to work,
+            // so there is probably a bug somewhere
+            //Q_ASSERT(false);
             m_insertMode = ShiftCellsRight; // faster than down
         }
     }
[prev in list] [next in list] [prev in thread] [next in thread]