[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kwin] effects/screenshot: Don't register a new service for screenshots
From:       David Edmundson <kde () davidedmundson ! co ! uk>
Date:       2016-11-25 10:15:21
Message-ID: E1cADXN-00037t-Ei () code ! kde ! org
[Download RAW message or body]

Git commit aae24bb07d60b603ee372b0372379379be68dadc by David Edmundson.
Committed on 25/11/2016 at 10:15.
Pushed by davidedmundson into branch 'master'.

Don't register a new service for screenshots

Summary:
If you're going to have kwin in the service name anyway there's
absolutely no benefit to having clients not use the existing
org.kde.KWin.

Test Plan: Object is still registered.

Reviewers: #plasma, graesslin

Reviewed By: #plasma, graesslin

Subscribers: graesslin, plasma-devel, kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D3357

M  +0    -2    effects/screenshot/screenshot.cpp

https://commits.kde.org/kwin/aae24bb07d60b603ee372b0372379379be68dadc

diff --git a/effects/screenshot/screenshot.cpp b/effects/screenshot/screens=
hot.cpp
index e948928..29dffe4 100644
--- a/effects/screenshot/screenshot.cpp
+++ b/effects/screenshot/screenshot.cpp
@@ -62,13 +62,11 @@ ScreenShotEffect::ScreenShotEffect()
 {
     connect ( effects, SIGNAL(windowClosed(KWin::EffectWindow*)), SLOT(win=
dowClosed(KWin::EffectWindow*)) );
     QDBusConnection::sessionBus().registerObject(QStringLiteral("/Screensh=
ot"), this, QDBusConnection::ExportScriptableContents);
-    QDBusConnection::sessionBus().registerService(QStringLiteral("org.kde.=
kwin.Screenshot"));
 }
 =

 ScreenShotEffect::~ScreenShotEffect()
 {
     QDBusConnection::sessionBus().unregisterObject(QStringLiteral("/Screen=
shot"));
-    QDBusConnection::sessionBus().unregisterService(QStringLiteral("org.kd=
e.kwin.Screenshot"));
 }
 =

 #ifdef KWIN_HAVE_XRENDER_COMPOSITING
[prev in list] [next in list] [prev in thread] [next in thread]