[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [messagelib] webengineviewer/src/checkphishingurl: Store filename
From:       Montel Laurent <montel () kde ! org>
Date:       2016-11-22 12:58:43
Message-ID: E1c9Aep-0005DA-1j () code ! kde ! org
[Download RAW message or body]

Git commit 7428be23354ca4be8252df646f8f04c61b32433b by Montel Laurent.
Committed on 22/11/2016 at 12:48.
Pushed by mlaurent into branch 'master'.

Store filename

M  +7    -0    webengineviewer/src/checkphishingurl/autotests/createdatabasefilejobtest.cpp
 M  +2    -0    webengineviewer/src/checkphishingurl/autotests/createdatabasefilejobtest.h
 M  +6    -1    webengineviewer/src/checkphishingurl/createdatabasefilejob.cpp
M  +3    -0    webengineviewer/src/checkphishingurl/createdatabasefilejob.h

http://commits.kde.org/messagelib/7428be23354ca4be8252df646f8f04c61b32433b

diff --git a/webengineviewer/src/checkphishingurl/autotests/createdatabasefilejobtest.cpp \
b/webengineviewer/src/checkphishingurl/autotests/createdatabasefilejobtest.cpp index \
                c1b66fc..f789062 100644
--- a/webengineviewer/src/checkphishingurl/autotests/createdatabasefilejobtest.cpp
+++ b/webengineviewer/src/checkphishingurl/autotests/createdatabasefilejobtest.cpp
@@ -18,6 +18,7 @@
 */
 
 #include "createdatabasefilejobtest.h"
+#include "../createdatabasefilejob.h"
 
 #include <QTest>
 
@@ -32,4 +33,10 @@ CreateDatabaseFileJobTest::~CreateDatabaseFileJobTest()
 
 }
 
+void CreateDatabaseFileJobTest::shouldHaveDefaultValue()
+{
+    WebEngineViewer::CreateDatabaseFileJob job;
+    QVERIFY(!job.canStart());
+}
+
 QTEST_MAIN(CreateDatabaseFileJobTest)
diff --git a/webengineviewer/src/checkphishingurl/autotests/createdatabasefilejobtest.h \
b/webengineviewer/src/checkphishingurl/autotests/createdatabasefilejobtest.h index \
                9640d06..3bce39d 100644
--- a/webengineviewer/src/checkphishingurl/autotests/createdatabasefilejobtest.h
+++ b/webengineviewer/src/checkphishingurl/autotests/createdatabasefilejobtest.h
@@ -28,6 +28,8 @@ class CreateDatabaseFileJobTest : public QObject
 public:
     explicit CreateDatabaseFileJobTest(QObject *parent = Q_NULLPTR);
     ~CreateDatabaseFileJobTest();
+private Q_SLOTS:
+    void shouldHaveDefaultValue();
 };
 
 #endif // CREATEDATABASEFILEJOBTEST_H
diff --git a/webengineviewer/src/checkphishingurl/createdatabasefilejob.cpp \
b/webengineviewer/src/checkphishingurl/createdatabasefilejob.cpp index \
                3549280..d4b6b18 100644
--- a/webengineviewer/src/checkphishingurl/createdatabasefilejob.cpp
+++ b/webengineviewer/src/checkphishingurl/createdatabasefilejob.cpp
@@ -32,6 +32,11 @@ CreateDatabaseFileJob::~CreateDatabaseFileJob()
 
 }
 
+bool CreateDatabaseFileJob::canStart() const
+{
+    return !mFileName.isEmpty();
+}
+
 void CreateDatabaseFileJob::start()
 {
     //TODO
@@ -39,5 +44,5 @@ void CreateDatabaseFileJob::start()
 
 void CreateDatabaseFileJob::setFileName(const QString &filename)
 {
-    //TODO
+    mFileName = filename;
 }
diff --git a/webengineviewer/src/checkphishingurl/createdatabasefilejob.h \
b/webengineviewer/src/checkphishingurl/createdatabasefilejob.h index 58b1f4b..1b37d99 \
                100644
--- a/webengineviewer/src/checkphishingurl/createdatabasefilejob.h
+++ b/webengineviewer/src/checkphishingurl/createdatabasefilejob.h
@@ -33,6 +33,9 @@ public:
     ~CreateDatabaseFileJob();
     void start();
     void setFileName(const QString &filename);
+    bool canStart() const;
+private:
+    QString mFileName;
 };
 }
 


[prev in list] [next in list] [prev in thread] [next in thread]