[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [skrooge] /: Impossible to duplicate a page not having selection (eg. Dashboard, monthly report)
From:       Stephane Mankowski <stephane () mankowski ! fr>
Date:       2016-11-20 17:48:53
Message-ID: E1c8WEX-0004Zp-7i () code ! kde ! org
[Download RAW message or body]

Git commit 79900af4dd3282de05e3cf775a5da7b8ee5c1927 by Stephane Mankowski.
Committed on 20/11/2016 at 17:48.
Pushed by smankowski into branch 'master'.

Impossible to duplicate a page not having selection (eg. Dashboard, monthly report)

M  +1    -0    CHANGELOG
M  +1    -1    plugins/generic/skg_selectall/skgselectallplugin.cpp
M  +1    -1    skgbasegui/skgmainpanel.cpp

http://commits.kde.org/skrooge/79900af4dd3282de05e3cf775a5da7b8ee5c1927

diff --git a/CHANGELOG b/CHANGELOG
index bcec302..7f2c196 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -10,6 +10,7 @@ skrooge (2.6.0)
   *Correction: Better performances and memory use in \
                SKGAccountObject::getPossibleReconciliations  
   *Correction: Better automatic account selection by using bank and agency numbers
   *Correction: Bad unit symbols in min and max limits in accounts page  
+  *Correction: Impossible to duplicate a page not having selection (eg. Dashboard, \
                monthly report)  
   *New feature: Addition of "nocolor" to the "money" Grantlee filter
   *New feature: Remove .skg in backup file name if .skg is added in the prefix \
(https://forum.kde.org/viewtopic.php?f=210&t=136518&p=366065#p366065)    
diff --git a/plugins/generic/skg_selectall/skgselectallplugin.cpp \
b/plugins/generic/skg_selectall/skgselectallplugin.cpp index 496b777..47df2bb 100644
--- a/plugins/generic/skg_selectall/skgselectallplugin.cpp
+++ b/plugins/generic/skg_selectall/skgselectallplugin.cpp
@@ -64,7 +64,7 @@ bool SKGSelectAllPlugin::setupActions(SKGDocument* iDocument, const \
QStringList&  setXMLFile(QStringLiteral("skg_selectall.rc"));
 
     // Menu
-    registerGlobalAction(QStringLiteral("edit_select_all"), \
actionCollection()->addAction(KStandardAction::SelectAll, \
QStringLiteral("edit_select_all"), this, SLOT(onSelectAll())), QStringList(), -1); +  \
registerGlobalAction(QStringLiteral("edit_select_all"), \
actionCollection()->addAction(KStandardAction::SelectAll, \
QStringLiteral("edit_select_all"), this, SLOT(onSelectAll())), QStringList(), 0);  \
return true;  }
 
diff --git a/skgbasegui/skgmainpanel.cpp b/skgbasegui/skgmainpanel.cpp
index 3f5ab7c..f04c68f 100644
--- a/skgbasegui/skgmainpanel.cpp
+++ b/skgbasegui/skgmainpanel.cpp
@@ -1670,7 +1670,7 @@ void SKGMainPanel::refresh()
             SKGTabPage* page = SKGMainPanel::getMainPanel()->currentPage();
             if (page) {
                 QAbstractItemView* view = \
                qobject_cast<QAbstractItemView*>(page->mainWidget());
-                enabled = (actDetails.min == 0 || view != nullptr);
+                enabled = (actDetails.min == -1 || view != nullptr);
             } else {
                 enabled = false;
             }


[prev in list] [next in list] [prev in thread] [next in thread]