[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kbibtex/kbibtex/0.7] src/program: Testing object for not being NULL
From:       Thomas Fischer <fischer () unix-ag ! uni-kl ! de>
Date:       2016-11-19 22:12:24
Message-ID: E1c8Ds0-0001ai-Op () code ! kde ! org
[Download RAW message or body]

Git commit 411f8996c100ad8501de181f0ef734974a7edcdd by Thomas Fischer.
Committed on 19/11/2016 at 21:47.
Pushed by thomasfischer into branch 'kbibtex/0.7'.

Testing object for not being NULL

Addressing a warning from 'scan-build':
Called C++ object pointer is null
by checking the referred-to object for not being NULL before
accessing its member.

M  +1    -1    src/program/openfileinfo.cpp

http://commits.kde.org/kbibtex/411f8996c100ad8501de181f0ef734974a7edcdd

diff --git a/src/program/openfileinfo.cpp b/src/program/openfileinfo.cpp
index 58f66bd..6fc8267 100644
--- a/src/program/openfileinfo.cpp
+++ b/src/program/openfileinfo.cpp
@@ -613,7 +613,7 @@ void OpenFileInfoManager::setCurrentFile(OpenFileInfo *openFileInfo, KService::P
     if (hasChanged) {
         if (previous != NULL) previous->setLastAccess();
         emit currentChanged(openFileInfo, servicePtr);
-    } else if (servicePtr != openFileInfo->currentService())
+    } else if (openFileInfo == NULL || servicePtr != openFileInfo->currentService())
         emit currentChanged(openFileInfo, servicePtr);
 }
 
[prev in list] [next in list] [prev in thread] [next in thread]