[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [plasma-workspace/Plasma/5.8] runners/windowedwidgets: Check KPluginInfo.service() returns a valid o
From:       David Edmundson <kde () davidedmundson ! co ! uk>
Date:       2016-11-17 10:55:52
Message-ID: E1c7KMC-0003H9-Er () code ! kde ! org
[Download RAW message or body]

Git commit 238ec3ee671bcf6716348122bebefb20c25d1101 by David Edmundson.
Committed on 17/11/2016 at 10:55.
Pushed by davidedmundson into branch 'Plasma/5.8'.

Check KPluginInfo.service() returns a valid object

Reviewed-by: Marco Martin

M  +1    -1    runners/windowedwidgets/windowedwidgetsrunner.cpp

http://commits.kde.org/plasma-workspace/238ec3ee671bcf6716348122bebefb20c25d1101

diff --git a/runners/windowedwidgets/windowedwidgetsrunner.cpp \
b/runners/windowedwidgets/windowedwidgetsrunner.cpp index f86159a..46c7e40 100644
--- a/runners/windowedwidgets/windowedwidgetsrunner.cpp
+++ b/runners/windowedwidgets/windowedwidgetsrunner.cpp
@@ -63,7 +63,7 @@ void WindowedWidgetsRunner::match(Plasma::RunnerContext &context)
 
     foreach (const KPluginInfo &info, \
Plasma::PluginLoader::self()->listAppletInfo(QString())) {  KService::Ptr service = \
                info.service();
-        if (!service->isValid()) {
+        if (!service || !service->isValid()) {
             continue;
         }
 


[prev in list] [next in list] [prev in thread] [next in thread]