[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [messagelib] webengineviewer/src/checkphishingurl: Clean up
From:       Montel Laurent <montel () kde ! org>
Date:       2016-11-08 7:19:50
Message-ID: E1c40hC-0001PD-5k () code ! kde ! org
[Download RAW message or body]

Git commit 9e8beaad47a696a6b5b7ef7860227575adb9d21e by Montel Laurent.
Committed on 08/11/2016 at 06:57.
Pushed by mlaurent into branch 'master'.

Clean up

M  +1    -5    webengineviewer/src/checkphishingurl/checkphishingurljob.cpp

http://commits.kde.org/messagelib/9e8beaad47a696a6b5b7ef7860227575adb9d21e

diff --git a/webengineviewer/src/checkphishingurl/checkphishingurljob.cpp \
b/webengineviewer/src/checkphishingurl/checkphishingurljob.cpp index 025a059..30283b4 \
                100644
--- a/webengineviewer/src/checkphishingurl/checkphishingurljob.cpp
+++ b/webengineviewer/src/checkphishingurl/checkphishingurljob.cpp
@@ -80,8 +80,6 @@ void CheckPhishingUrlJob::parse(const QByteArray &replyStr)
 void CheckPhishingUrlJob::slotCheckUrlFinished(QNetworkReply *reply)
 {
     parse(reply->readAll());
-    //TODO extract info from
-    //TODO Q_EMIT result(MessageViewer::CheckPhishingUrlJob:: ?);
     reply->deleteLater();
     deleteLater();
 }
@@ -147,7 +145,7 @@ void CheckPhishingUrlJob::start()
     } else if (canStart()) {
         QUrl safeUrl = \
QUrl(QStringLiteral("https://safebrowsing.googleapis.com/v4/threatMatches:find"));  \
                safeUrl.addQueryItem(QStringLiteral("key"), apiKey());
-        qDebug() << " safeUrl" << safeUrl;
+        //qDebug() << " safeUrl" << safeUrl;
         QNetworkRequest request(safeUrl);
         request.setHeader(QNetworkRequest::ContentTypeHeader, \
QStringLiteral("application/json"));  
@@ -168,8 +166,6 @@ void CheckPhishingUrlJob::slotError(QNetworkReply::NetworkError \
error)  {
     QNetworkReply *reply = qobject_cast<QNetworkReply *>(sender());
     qCDebug(WEBENGINEVIEWER_LOG)<<" error "<<error << " error string : "<< \
                reply->errorString();
-    //mErrorMsg = reply->errorString();
-    //FIXME
     reply->deleteLater();
     Q_EMIT result(WebEngineViewer::CheckPhishingUrlJob::Unknown, mUrl);
     deleteLater();


[prev in list] [next in list] [prev in thread] [next in thread]