[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [konsole] src: Change close activate view to Ctrl+Shift+X to avoid duplicate
From:       Kurt Hindenburg <kurt.hindenburg () gmail ! com>
Date:       2016-11-07 19:23:33
Message-ID: E1c3pW1-00074D-Hh () code ! kde ! org
[Download RAW message or body]

Git commit f2358180683f96b1c47e1a441f45c88460fc23b5 by Kurt Hindenburg.
Committed on 07/11/2016 at 19:21.
Pushed by hindenburg into branch 'master'.

Change close activate view to Ctrl+Shift+X to avoid duplicate

The key sequence 'Ctrl+Shift+S' is ambiguous. Use 'Configure Shortcuts'
from the 'Settings' menu to solve the ambiguity. This shortcut was used
repeated times.

Now its changed to CTRL+SHIFT+X. For closing active tab in the konsole
of the split screen, it uses CTRL+SHIFT+X

Thanks to Aniketh Girish anikethgireesh gmail com

REVIEW: 129305
BUG: 354954

M  +1    -1    src/ViewManager.cpp

http://commits.kde.org/konsole/f2358180683f96b1c47e1a441f45c88460fc23b5

diff --git a/src/ViewManager.cpp b/src/ViewManager.cpp
index 81ccab1..2857c81 100644
--- a/src/ViewManager.cpp
+++ b/src/ViewManager.cpp
@@ -155,7 +155,7 @@ void ViewManager::setupActions()
 
         QAction* closeActiveAction = new QAction(i18nc("@action:inmenu Close Active \
                View", "Close Active") , this);
         closeActiveAction->setIcon(QIcon::fromTheme(QStringLiteral("view-close")));
-        collection->setDefaultShortcut(closeActiveAction, Qt::CTRL + Qt::SHIFT + \
Qt::Key_S); +        collection->setDefaultShortcut(closeActiveAction, Qt::CTRL + \
Qt::SHIFT + Qt::Key_X);  closeActiveAction->setEnabled(false);
         collection->addAction("close-active-view", closeActiveAction);
         connect(closeActiveAction , &QAction::triggered , this , \
&Konsole::ViewManager::closeActiveContainer);


[prev in list] [next in list] [prev in thread] [next in thread]