[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [discover] libdiscover/backends/PackageKitBackend: trivial: Fix minor AppStream porting quirk
From:       Matthias Klumpp <matthias () tenstral ! net>
Date:       2016-10-31 23:10:37
Message-ID: E1c1Liv-0003j0-WE () code ! kde ! org
[Download RAW message or body]

Git commit f2bd85ec4025c2b14acdac9e018a00ea9b14e520 by Matthias Klumpp.
Committed on 31/10/2016 at 23:09.
Pushed by matthiask into branch 'master'.

trivial: Fix minor AppStream porting quirk

We didn't need to drop the assert (I wonder if we should fail better in
case of a broken component?), also fix the warning in case we failed to
load the data pool.

M  +1    -0    libdiscover/backends/PackageKitBackend/AppPackageKitResource.cpp
M  +1    -1    libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp

http://commits.kde.org/discover/f2bd85ec4025c2b14acdac9e018a00ea9b14e520

diff --git a/libdiscover/backends/PackageKitBackend/AppPackageKitResource.cpp \
b/libdiscover/backends/PackageKitBackend/AppPackageKitResource.cpp index \
                2a04c17..7b116b7 100644
--- a/libdiscover/backends/PackageKitBackend/AppPackageKitResource.cpp
+++ b/libdiscover/backends/PackageKitBackend/AppPackageKitResource.cpp
@@ -33,6 +33,7 @@ AppPackageKitResource::AppPackageKitResource(const \
AppStream::Component& data, c  : PackageKitResource(packageName, QString(), parent)
     , m_appdata(data)
 {
+    Q_ASSERT(data.isValid());
 }
 
 QString AppPackageKitResource::name()
diff --git a/libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp \
b/libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp index 15d9ada..3143beb \
                100644
--- a/libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp
+++ b/libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp
@@ -56,7 +56,7 @@ PackageKitBackend::PackageKitBackend(QObject* parent)
 {
     bool b = m_appdata.load();
     if (!b) {
-        qWarning() << "Couldn't load the AppStream database";
+        qWarning() << "Could not open the AppStream metadata pool";
 
         auto msg = new QAction(i18n("Got it"), this);
         msg->setWhatsThis(i18n("Please make sure that Appstream is properly set up \
on your system"));


[prev in list] [next in list] [prev in thread] [next in thread]