[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdesvn] src/svnfrontend: Fix crash when adding a new property - using PropertyListViewItem::setFoo(
From:       Christian Ehrlicher <Ch.Ehrlicher () gmx ! de>
Date:       2016-10-24 18:28:20
Message-ID: E1byjyu-00060n-47 () code ! kde ! org
[Download RAW message or body]

Git commit 858703b96b139804d1bbff54741c921da2a029c8 by Christian Ehrlicher.
Committed on 24/10/2016 at 18:26.
Pushed by chehrlic into branch 'master'.

Fix crash when adding a new property - using PropertyListViewItem::setFoo() functions \
will result in some signal/slot invocations which result in a delete of this item ... \
time to switch to a real model

M  +1    -5    src/svnfrontend/propertiesdlg.cpp

http://commits.kde.org/kdesvn/858703b96b139804d1bbff54741c921da2a029c8

diff --git a/src/svnfrontend/propertiesdlg.cpp b/src/svnfrontend/propertiesdlg.cpp
index 4ce1913..6596fe4 100644
--- a/src/svnfrontend/propertiesdlg.cpp
+++ b/src/svnfrontend/propertiesdlg.cpp
@@ -124,11 +124,7 @@ void PropertiesDlg::slotAdd()
             KMessageBox::error(this, i18n("A property with that name \
exists.\nRejecting it."), i18n("Double property"));  return;
         }
-        PropertyListViewItem *ki = new PropertyListViewItem(m_ui->tvPropertyList);
-        ki->setText(0, dlg->propName());
-        ki->setText(1, dlg->propValue());
-        ki->checkName();
-        ki->checkValue();
+        new PropertyListViewItem(m_ui->tvPropertyList, dlg->propName(), \
dlg->propValue());  }
     delete dlg;
 }


[prev in list] [next in list] [prev in thread] [next in thread]