[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kgpg] /: only refresh keys after importing if at least one key was received
From:       Rolf Eike Beer <kde () opensource ! sf-tec ! de>
Date:       2016-10-21 21:26:45
Message-ID: E1bxhKv-00044w-TJ () code ! kde ! org
[Download RAW message or body]

Git commit f8d02bcb5768d58686110689030686afbc496c4e by Rolf Eike Beer.
Committed on 21/10/2016 at 18:08.
Pushed by dakon into branch 'master'.

only refresh keys after importing if at least one key was received

Otherwise all keys would have been reloaded when nothing was actually changed.

M  +2    -2    keysmanager.cpp

http://commits.kde.org/kgpg/f8d02bcb5768d58686110689030686afbc496c4e

diff --git a/keysmanager.cpp b/keysmanager.cpp
index 3bce780..061fee9 100644
--- a/keysmanager.cpp
+++ b/keysmanager.cpp
@@ -2180,11 +2180,11 @@ void KeysManager::importRemoteFinished(int result)
 	KGpgReceiveKeys *t = qobject_cast<KGpgReceiveKeys *>(sender());
 	Q_ASSERT(t != Q_NULLPTR);
 
-	const QStringList keys(KGpgImport::getImportedIds(t->getLog()));
+	const QStringList keys = KGpgImport::getImportedIds(t->getLog());
 
 	t->deleteLater();
 
-	if (result == KGpgTransaction::TS_OK)
+	if ((result == KGpgTransaction::TS_OK) && !keys.isEmpty())
 		imodel->refreshKeys(keys);
 }
 

[prev in list] [next in list] [prev in thread] [next in thread]