[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [dferry] serialization: Remove Arguments::Writer::Private::ArrayInfo::dataBegin
From:       Andreas Hartmetz <ahartmetz () gmail ! com>
Date:       2016-10-12 0:57:07
Message-ID: E1bu7r1-0007PZ-Tu () code ! kde ! org
[Download RAW message or body]

Git commit 79b069f19bd504fd5189e4cf66322e71e455a106 by Andreas Hartmetz.
Committed on 11/10/2016 at 22:08.
Pushed by ahartmetz into branch 'master'.

Remove Arguments::Writer::Private::ArrayInfo::dataBegin

I think it was meant to check array length, but that one is
better checked when the final placement is determined in
finishInternal(). That is already done there.
This may need to be brought back when memmove()-style
in-place serialization is implemented, but for now it's only
clutter.

M  +0    -2    serialization/arguments.cpp

http://commits.kde.org/dferry/79b069f19bd504fd5189e4cf66322e71e455a106

diff --git a/serialization/arguments.cpp b/serialization/arguments.cpp
index 2783a66..d6f3cad 100644
--- a/serialization/arguments.cpp
+++ b/serialization/arguments.cpp
@@ -209,7 +209,6 @@ public:
 
     struct ArrayInfo
     {
-        uint32 dataBegin; // one past the last data byte of the array
         uint32 containedTypeBegin; // to rewind when reading the next element
     };
 
@@ -2048,7 +2047,6 @@ void Arguments::Writer::advanceState(cstring signatureFragment, IoState newState
             VALID_IF(d->m_nesting.beginParen(), Error::ExcessiveNesting);
         }
         aggregateInfo.aggregateType = m_state;
-        aggregateInfo.arr.dataBegin = d->m_dataPosition;
         aggregateInfo.arr.containedTypeBegin = d->m_signaturePosition;
         d->m_aggregateStack.reserve(8);
         d->m_aggregateStack.push_back(aggregateInfo);

[prev in list] [next in list] [prev in thread] [next in thread]