[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdesvn] src/kiosvn: Object -> const ref for StreamWrittenCb::streamPushData()
From:       Christian Ehrlicher <Ch.Ehrlicher () gmx ! de>
Date:       2016-10-09 13:16:16
Message-ID: E1btDxg-0003lJ-I3 () code ! kde ! org
[Download RAW message or body]

Git commit 16fecbcbf2a4377c911dbe6d9015e53a2348ee5d by Christian Ehrlicher.
Committed on 09/10/2016 at 11:14.
Pushed by chehrlic into branch 'master'.

Object -> const ref for StreamWrittenCb::streamPushData()

M  +5    -5    src/kiosvn/kiobytestream.h
M  +2    -2    src/kiosvn/kiosvn.cpp
M  +1    -1    src/kiosvn/kiosvn.h

http://commits.kde.org/kdesvn/16fecbcbf2a4377c911dbe6d9015e53a2348ee5d

diff --git a/src/kiosvn/kiobytestream.h b/src/kiosvn/kiobytestream.h
index 2b1d8cd..f10b869 100644
--- a/src/kiosvn/kiobytestream.h
+++ b/src/kiosvn/kiobytestream.h
@@ -24,15 +24,15 @@
 
 #include <kio/global.h>
 #include <QMimeType>
-#include <QTime>
+#include <QElapsedTimer>
 
 class StreamWrittenCb
 {
 public:
-    StreamWrittenCb() {}
-    virtual ~StreamWrittenCb() {}
+    StreamWrittenCb() = default;
+    virtual ~StreamWrittenCb() = default;
     virtual void streamWritten(const KIO::filesize_t current) = 0;
-    virtual void streamPushData(QByteArray) = 0;
+    virtual void streamPushData(const QByteArray &streamData) = 0;
     virtual void streamSendMime(const QMimeType &mt) = 0;
 };
 
@@ -60,7 +60,7 @@ protected:
     bool m_mimeSend;
     QString m_Filename;
     QByteArray array;
-    QTime m_MessageTick;
+    QElapsedTimer m_MessageTick;
 };
 
 #endif
diff --git a/src/kiosvn/kiosvn.cpp b/src/kiosvn/kiosvn.cpp
index fc78f28..116f8d3 100644
--- a/src/kiosvn/kiosvn.cpp
+++ b/src/kiosvn/kiosvn.cpp
@@ -1013,9 +1013,9 @@ void kio_svnProtocol::streamSendMime(const QMimeType &mt)
     }
 }
 
-void kio_svnProtocol::streamPushData(QByteArray array)
+void kio_svnProtocol::streamPushData(const QByteArray &streamData)
 {
-    data(array);
+    data(streamData);
 }
 
 void kio_svnProtocol::contextProgress(long long int current, long long int max)
diff --git a/src/kiosvn/kiosvn.h b/src/kiosvn/kiosvn.h
index 299130d..e2f88bb 100644
--- a/src/kiosvn/kiosvn.h
+++ b/src/kiosvn/kiosvn.h
@@ -59,7 +59,7 @@ public:
     virtual void special(const QByteArray &data) override;
     // StreamWrittenCb
     virtual void streamWritten(const KIO::filesize_t current) override;
-    virtual void streamPushData(QByteArray) override;
+    virtual void streamPushData(const QByteArray &streamData) override;
     virtual void streamSendMime(const QMimeType &mt) override;
 
     void contextProgress(long long int current, long long int max);

[prev in list] [next in list] [prev in thread] [next in thread]