[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdevplatform/5.0] language/duchain: Share code instead of duplicating it
From:       Milian Wolff <mail () milianw ! de>
Date:       2016-09-21 19:35:05
Message-ID: E1bmnIP-0004Js-B0 () code ! kde ! org
[Download RAW message or body]

Git commit 46a720a58f9111f7dd2c0a7dea291bebd6491368 by Milian Wolff.
Committed on 21/09/2016 at 18:37.
Pushed by mwolff into branch '5.0'.

Share code instead of duplicating it

M  +3    -8    language/duchain/topducontextdynamicdata.cpp

http://commits.kde.org/kdevplatform/46a720a58f9111f7dd2c0a7dea291bebd6491368

diff --git a/language/duchain/topducontextdynamicdata.cpp b/language/duchain/topducontextdynamicdata.cpp
index c56fac0..278b04d 100644
--- a/language/duchain/topducontextdynamicdata.cpp
+++ b/language/duchain/topducontextdynamicdata.cpp
@@ -449,19 +449,14 @@ void TopDUContextDynamicData::DUChainItemStorage<Item>::writeData(QFile* file)
 
 //END DUChainItemStorage
 
-const char* KDevelop::TopDUContextDynamicData::pointerInData(uint totalOffset) const {
+const char* TopDUContextDynamicData::pointerInData(uint totalOffset) const
+{
   Q_ASSERT(!m_mappedData || m_data.isEmpty());
 
   if(m_mappedData && m_mappedDataSize)
     return (char*)m_mappedData + totalOffset;
 
-  for(int a = 0; a < m_data.size(); ++a) {
-    if(totalOffset < m_data[a].second)
-      return m_data[a].first.constData() + totalOffset;
-    totalOffset -= m_data[a].second;
-  }
-  Q_ASSERT(0); //Offset doesn't exist in the data
-  return 0;
+  return ::pointerInData(m_data, totalOffset);
 }
 
 TopDUContextDynamicData::TopDUContextDynamicData(TopDUContext* topContext)
[prev in list] [next in list] [prev in thread] [next in thread]