[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    =?utf-8?q?=5Bbaloo=5D_src/engine=3A_add_missing_close_env=2C_as_?= =?utf-8?q?pointed_out_by_Lo=C3=AF
From:       Christoph Cullmann <cullmann () kde ! org>
Date:       2016-09-11 20:33:27
Message-ID: E1bjBRP-00054v-Hh () code ! kde ! org
[Download RAW message or body]

Git commit 377e62b0307839edb0245d65381a3f55f594ae4e by Christoph Cullmann.
Committed on 11/09/2016 at 20:30.
Pushed by cullmann into branch 'master'.

add missing close env, as pointed out by Loïc Yhuel
Missed in my review diff :/

REVIEW: 128890
BUG: 353783

M  +1    -0    src/engine/database.cpp

http://commits.kde.org/baloo/377e62b0307839edb0245d65381a3f55f594ae4e

diff --git a/src/engine/database.cpp b/src/engine/database.cpp
index 37b8e97..c83f540 100644
--- a/src/engine/database.cpp
+++ b/src/engine/database.cpp
@@ -119,6 +119,7 @@ bool Database::open(OpenMode mode)
     QByteArray arr = QFile::encodeName(indexInfo.absoluteFilePath());
     rc = mdb_env_open(m_env, arr.constData(), MDB_NOSUBDIR | MDB_NOMEMINIT, 0664);
     if (rc) {
+        mdb_env_close(m_env);
         m_env = nullptr;
         return false;
     }
[prev in list] [next in list] [prev in thread] [next in thread]