[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [ktexteditor] src/vimode/emulatedcommandbar: Allows only one level of recursion
From:       Ivan Čukić <ivan.cukic () kde ! org>
Date:       2016-08-27 8:33:10
Message-ID: E1bdZ38-0001gd-1a () code ! kde ! org
[Download RAW message or body]

Git commit 51dddd021ef05e4254924bb7e71f2317543f1a42 by Ivan Čukić.
Committed on 27/08/2016 at 08:33.
Pushed by ivan into branch 'master'.

Allows only one level of recursion

Summary:
When one enters the underscore in the vim bar,
it infinitely recurses trying to process the
key pressed event [1].

This patch allows only one level of recursion.

[1] https://bugs.kde.org/show_bug.cgi?id=364650

Reviewers: cullmann, #kate, sstjames

Subscribers: kwrite-devel

Differential Revision: https://phabricator.kde.org/D2597

M  +1    -0    src/vimode/emulatedcommandbar/emulatedcommandbar.cpp

http://commits.kde.org/ktexteditor/51dddd021ef05e4254924bb7e71f2317543f1a42

diff --git a/src/vimode/emulatedcommandbar/emulatedcommandbar.cpp \
b/src/vimode/emulatedcommandbar/emulatedcommandbar.cpp index 3197981..257820b 100644
--- a/src/vimode/emulatedcommandbar/emulatedcommandbar.cpp
+++ b/src/vimode/emulatedcommandbar/emulatedcommandbar.cpp
@@ -305,6 +305,7 @@ bool EmulatedCommandBar::handleKeyPress(const QKeyEvent \
                *keyEvent)
     // in Visual Mode, Visual Line Mode, etc.  See VisualViMode::updateSelection( ).
     if (m_edit->isVisible())
     {
+        if (m_suspendEditEventFiltering) return false;
         m_suspendEditEventFiltering = true;
         QKeyEvent keyEventCopy(keyEvent->type(), keyEvent->key(), \
keyEvent->modifiers(), keyEvent->text(), keyEvent->isAutoRepeat(), \
keyEvent->count());  qApp->notify(m_edit, &keyEventCopy);


[prev in list] [next in list] [prev in thread] [next in thread]