[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [prison] /: Merge branch 'frameworks'
From:       Sune Vuorela <sune () vuorela ! dk>
Date:       2016-08-10 6:33:16
Message-ID: 1723082.HtOtmHBDy5 () dabney
[Download RAW message or body]

Hi David

Long story short, please don't release prison as part of frameworks until I 
have given an explicit go. There is a handful of commits I need to actually 
look at.


Hi Leslie

I'm quite surprised by this.

You have pushed ~10 unreviewed commits over the last 24 hours, where you have 
touched approximately all the files. 
The 1 I ended up actually looking detailed at required 2 further cleanup 
commits.

Please if you don't use the review infrastructure, please, give a bit of time 
for people, especially the maintainer, to actually review stuff before you 
declare them "stable".

Oh. and given the build server is asked to do a qt4 build of master, it looks 
like things might be failing ...


/Sune

On Wednesday 10 August 2016 01:13:10 Leslie Zhai wrote:
> Git commit 38960dd40fb54037a0684546409b5e646f3147cd by Leslie Zhai.
> Committed on 10/08/2016 at 01:12.
> Pushed by lesliezhai into branch 'master'.
> 
> Merge branch 'frameworks'
> 
> CCMAIL: faure@kde.org
> 
> 
> http://commits.kde.org/prison/38960dd40fb54037a0684546409b5e646f3147cd

-- 
I didn't stop pretending when I became an adult, it's just that when I was a 
kid I was pretending that I fit into the rules and structures of this world. 
And now that I'm an adult, I pretend that those rules and structures exist.
   - zefrank
[prev in list] [next in list] [prev in thread] [next in thread]