[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [messagelib] mimetreeparser/src/viewer: Fix memory leak when deleting MessageViewer and its NodeHelp
From:       David Faure <faure () kde ! org>
Date:       2016-07-31 19:48:25
Message-ID: E1bTwin-000660-DZ () code ! kde ! org
[Download RAW message or body]

Git commit 00283cb1f050fba17b5603038496271afc5277f9 by David Faure.
Committed on 31/07/2016 at 17:43.
Pushed by dfaure into branch 'master'.

Fix memory leak when deleting MessageViewer and its NodeHelper.

The Interface::BodyPartMemento(s) were not deleted.

Since they are deleted when switching messages, this is no severe
leak, it just showed up in a unittest.

M  +1    -0    mimetreeparser/src/viewer/nodehelper.cpp

http://commits.kde.org/messagelib/00283cb1f050fba17b5603038496271afc5277f9

diff --git a/mimetreeparser/src/viewer/nodehelper.cpp b/mimetreeparser/src/viewer/nodehelper.cpp
index ecf39f6..5942360 100644
--- a/mimetreeparser/src/viewer/nodehelper.cpp
+++ b/mimetreeparser/src/viewer/nodehelper.cpp
@@ -85,6 +85,7 @@ NodeHelper::~NodeHelper()
         delete mAttachmentFilesDir;
         mAttachmentFilesDir = 0;
     }
+    clear();
 }
 
 void NodeHelper::setNodeProcessed(KMime::Content *node, bool recurse)

[prev in list] [next in list] [prev in thread] [next in thread]