[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kmymoney] kmymoney/plugins/kbanking: Minor code improvements in MyMoneyBanking
From:       Christian_Dávid <christian-david () web ! de>
Date:       2016-07-31 19:39:50
Message-ID: E1bTwaU-0001ZQ-Jp () code ! kde ! org
[Download RAW message or body]

Git commit 1903380357a1d7712dff6745c1247823c3608468 by Christian Dávid.
Committed on 30/07/2016 at 21:21.
Pushed by christiand into branch 'master'.

Minor code improvements in MyMoneyBanking

Uses C++11.

M  +10   -8    kmymoney/plugins/kbanking/mymoneybanking.cpp

http://commits.kde.org/kmymoney/1903380357a1d7712dff6745c1247823c3608468

diff --git a/kmymoney/plugins/kbanking/mymoneybanking.cpp b/kmymoney/plugins/kbanking/mymoneybanking.cpp
index 26c2fb3..ad53d4b 100644
--- a/kmymoney/plugins/kbanking/mymoneybanking.cpp
+++ b/kmymoney/plugins/kbanking/mymoneybanking.cpp
@@ -26,6 +26,8 @@
 
 #include "mymoneybanking.h"
 
+#include <memory>
+
 // ----------------------------------------------------------------------------
 // QT Includes
 
@@ -100,7 +102,7 @@ public:
   Private() : passwordCacheTimer(0) {
     QString gwenProxy = QString::fromLocal8Bit(qgetenv("GWEN_PROXY"));
     if (gwenProxy.isEmpty()) {
-      KConfig *cfg = new KConfig("kioslaverc");
+      std::unique_ptr<KConfig> cfg = std::unique_ptr<KConfig>(new KConfig("kioslaverc"));
       QRegExp exp("(\\w+://)?([^/]{2}.+:\\d+)");
       QString proxy;
 
@@ -126,7 +128,6 @@ public:
           qDebug("KDE proxy setting of type %d not supported", type);
           break;
       }
-      delete cfg;
     }
   }
 
@@ -220,12 +221,13 @@ KBankingPlugin::~KBankingPlugin()
 void KBankingPlugin::loadProtocolConversion()
 {
   if (m_kbanking) {
-    m_protocolConversionMap.clear();
-    m_protocolConversionMap["aqhbci"] = "HBCI";
-    m_protocolConversionMap["aqofxconnect"] = "OFX";
-    m_protocolConversionMap["aqyellownet"] = "YellowNet";
-    m_protocolConversionMap["aqgeldkarte"] = "Geldkarte";
-    m_protocolConversionMap["aqdtaus"] = "DTAUS";
+    m_protocolConversionMap = {
+      {"aqhbci", "HBCI"},
+      {"aqofxconnect", "OFX"},
+      {"aqyellownet", "YellowNet"},
+      {"aqgeldkarte", "Geldkarte"},
+      {"aqdtaus", "DTAUS"}
+    };
   }
 }
 

[prev in list] [next in list] [prev in thread] [next in thread]