[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdepim-addons/Applications/16.08] plugins/webengineurlinterceptor/adblock/lib/widgets: Not necessar
From:       Montel Laurent <montel () kde ! org>
Date:       2016-07-19 11:43:47
Message-ID: E1bPTRD-0002Lj-21 () code ! kde ! org
[Download RAW message or body]

Git commit ece3900fbb9d7d0fac774a1732ea6a8eb9f1c046 by Montel Laurent.
Committed on 19/07/2016 at 11:28.
Pushed by mlaurent into branch 'Applications/16.08'.

Not necessary private Q_SLOTS here

M  +1    -3    plugins/webengineurlinterceptor/adblock/lib/widgets/adblockaddsubscriptiondialog.h
 M  +1    -3    plugins/webengineurlinterceptor/adblock/lib/widgets/adblockautomaticruleslistwidget.h
 M  +5    -5    plugins/webengineurlinterceptor/adblock/lib/widgets/adblockblockableitemswidget.cpp
 M  +2    -2    plugins/webengineurlinterceptor/adblock/lib/widgets/adblockblockableitemswidget.h
 M  +1    -3    plugins/webengineurlinterceptor/adblock/lib/widgets/adblockcreatefilterdialog.h


http://commits.kde.org/kdepim-addons/ece3900fbb9d7d0fac774a1732ea6a8eb9f1c046

diff --git a/plugins/webengineurlinterceptor/adblock/lib/widgets/adblockaddsubscriptiondialog.h \
b/plugins/webengineurlinterceptor/adblock/lib/widgets/adblockaddsubscriptiondialog.h \
                index 919d568..45e60ec 100644
--- a/plugins/webengineurlinterceptor/adblock/lib/widgets/adblockaddsubscriptiondialog.h
                
+++ b/plugins/webengineurlinterceptor/adblock/lib/widgets/adblockaddsubscriptiondialog.h
 @@ -35,10 +35,8 @@ public:
 
     void selectedList(QString &name, QString &url);
 
-private Q_SLOTS:
-    void slotShowList();
-
 private:
+    void slotShowList();
     void initializeList(const QStringList &excludeList);
     QComboBox *mListSubscription;
     QToolButton *mShowList;
diff --git a/plugins/webengineurlinterceptor/adblock/lib/widgets/adblockautomaticruleslistwidget.h \
b/plugins/webengineurlinterceptor/adblock/lib/widgets/adblockautomaticruleslistwidget.h
 index 49c42cc..4b00c81 100644
--- a/plugins/webengineurlinterceptor/adblock/lib/widgets/adblockautomaticruleslistwidget.h
                
+++ b/plugins/webengineurlinterceptor/adblock/lib/widgets/adblockautomaticruleslistwidget.h
 @@ -35,10 +35,8 @@ public:
     void setDisabledRules(const QStringList &disabledRules);
     QStringList disabledRules() const;
 
-private Q_SLOTS:
-    void slotItemChanged(QListWidgetItem *item);
-
 private:
+    void slotItemChanged(QListWidgetItem *item);
     void updateItem(QListWidgetItem *item);
     void createItem(const QString &rule);
     QStringList mDisabledRules;
diff --git a/plugins/webengineurlinterceptor/adblock/lib/widgets/adblockblockableitemswidget.cpp \
b/plugins/webengineurlinterceptor/adblock/lib/widgets/adblockblockableitemswidget.cpp \
                index 429e70e..2b53854 100644
--- a/plugins/webengineurlinterceptor/adblock/lib/widgets/adblockblockableitemswidget.cpp
                
+++ b/plugins/webengineurlinterceptor/adblock/lib/widgets/adblockblockableitemswidget.cpp
 @@ -101,17 +101,17 @@ void \
AdBlockBlockableItemsWidget::customContextMenuRequested(const QPoint &)  }
 
     QMenu menu;
-    menu.addAction(QIcon::fromTheme(QStringLiteral("edit-copy")), i18n("Copy url"), \
this, SLOT(slotCopyItem())); +    \
menu.addAction(QIcon::fromTheme(QStringLiteral("edit-copy")), i18n("Copy url"), this, \
                &AdBlockBlockableItemsWidget::slotCopyItem);
     const bool filterValueIsNotEmpty = !item->text(FilterValue).isEmpty();
     if (filterValueIsNotEmpty) {
-        menu.addAction(QIcon::fromTheme(QStringLiteral("edit-copy")), i18n("Copy \
filter"), this, SLOT(slotCopyFilterItem())); +        \
menu.addAction(QIcon::fromTheme(QStringLiteral("edit-copy")), i18n("Copy filter"), \
this, &AdBlockBlockableItemsWidget::slotCopyFilterItem);  }
-    menu.addAction(i18n("Block item..."), this, SLOT(slotBlockItem()));
+    menu.addAction(i18n("Block item..."), this, \
&AdBlockBlockableItemsWidget::slotBlockItem);  menu.addSeparator();
-    menu.addAction(QIcon::fromTheme(QStringLiteral("document-open")), i18n("Open"), \
this, SLOT(slotOpenItem())); +    \
menu.addAction(QIcon::fromTheme(QStringLiteral("document-open")), i18n("Open"), this, \
&AdBlockBlockableItemsWidget::slotOpenItem);  if (filterValueIsNotEmpty) {
         menu.addSeparator();
-        menu.addAction(QIcon::fromTheme(QStringLiteral("edit-delete")), i18n("Remove \
filter"), this, SLOT(slotRemoveFilter())); +        \
menu.addAction(QIcon::fromTheme(QStringLiteral("edit-delete")), i18n("Remove \
filter"), this, &AdBlockBlockableItemsWidget::slotRemoveFilter);  }
     menu.exec(QCursor::pos());
 }
diff --git a/plugins/webengineurlinterceptor/adblock/lib/widgets/adblockblockableitemswidget.h \
b/plugins/webengineurlinterceptor/adblock/lib/widgets/adblockblockableitemswidget.h \
                index 2e5f466..831490c 100644
--- a/plugins/webengineurlinterceptor/adblock/lib/widgets/adblockblockableitemswidget.h
                
+++ b/plugins/webengineurlinterceptor/adblock/lib/widgets/adblockblockableitemswidget.h
 @@ -55,14 +55,14 @@ public:
 
     static QString elementType(AdBlockBlockableItemsWidget::TypeElement type);
     static QString elementTypeToI18n(AdBlockBlockableItemsWidget::TypeElement type);
-private Q_SLOTS:
+
+private:
     void customContextMenuRequested(const QPoint &);
     void slotCopyFilterItem();
     void slotOpenItem();
     void slotBlockItem();
     void slotCopyItem();
     void slotRemoveFilter();
-private:
     enum BlockType {
         FilterValue = 0,
         Url,
diff --git a/plugins/webengineurlinterceptor/adblock/lib/widgets/adblockcreatefilterdialog.h \
b/plugins/webengineurlinterceptor/adblock/lib/widgets/adblockcreatefilterdialog.h \
                index 74c040c..2f7fbde 100644
--- a/plugins/webengineurlinterceptor/adblock/lib/widgets/adblockcreatefilterdialog.h
+++ b/plugins/webengineurlinterceptor/adblock/lib/widgets/adblockcreatefilterdialog.h
@@ -40,10 +40,8 @@ public:
 
     QString filter() const;
 
-private Q_SLOTS:
-    void slotUpdateFilter();
-
 private:
+    void slotUpdateFilter();
     enum ElementType {
         ElementValue = Qt::UserRole + 1
     };


[prev in list] [next in list] [prev in thread] [next in thread]