[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kdelibs/KDE/4.14] kdecore/kconfig_compiler: Fix reproducibility in builds by ensuring utf-8 encodin
From:       Scarlett Clark <scarlett () scarlettgatelyclark ! com>
Date:       2016-06-22 15:50:37
Message-ID: E1bFkQH-0005w6-6P () code ! kde ! org
[Download RAW message or body]

Git commit d6655e34f05516b9e857e8b2e1a9238c33875924 by Scarlett Clark.
Committed on 22/06/2016 at 15:42.
Pushed by scarlettclark into branch 'KDE/4.14'.

Fix reproducibility in builds by ensuring utf-8 encoding.

REVIEW:128102
Set encoding on kconfig_compiler generated cpp and headers
to utf-8 ( reproducible builds ) Under certain locals non
standard characters will get dropped making builds un reproducible.
Setting the encoding to utf-8 on the files makes all builds reproducible
no matter what ( or none ) locale is in use. Thereby making the build reproducible.

M  +2    -1    kdecore/kconfig_compiler/kconfig_compiler.cpp

http://commits.kde.org/kdelibs/d6655e34f05516b9e857e8b2e1a9238c33875924

diff --git a/kdecore/kconfig_compiler/kconfig_compiler.cpp \
b/kdecore/kconfig_compiler/kconfig_compiler.cpp index 30f52ab1..89d0edf 100644
--- a/kdecore/kconfig_compiler/kconfig_compiler.cpp
+++ b/kdecore/kconfig_compiler/kconfig_compiler.cpp
@@ -1486,6 +1486,7 @@ int main( int argc, char **argv )
 
   QTextStream h( &header );
 
+  h.setCodec("utf-8");
   h << "// This file is generated by kconfig_compiler from " << \
QFileInfo(inputFilename).fileName() << "." << endl;  h << "// All changes you do to \
this file will be lost." << endl;  
@@ -1908,7 +1909,7 @@ int main( int argc, char **argv )
 
   QTextStream cpp( &implementation );
 
-
+  cpp.setCodec("utf-8");
   cpp << "// This file is generated by kconfig_compiler from " << \
QFileInfo(inputFilename).fileName() << "." << endl;  cpp << "// All changes you do to \
this file will be lost." << endl << endl;  


[prev in list] [next in list] [prev in thread] [next in thread]