[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kpimtextedit] src/texteditor/commonwidget: Add missing parent for child widget, which messed up tab
From:       David Faure <faure () kde ! org>
Date:       2016-05-31 19:32:34
Message-ID: E1b7pP0-0000oT-4s () scm ! kde ! org
[Download RAW message or body]

Git commit 3d28f62956584b72528aea0e6416e49bb9d1d2f4 by David Faure.
Committed on 31/05/2016 at 19:31.
Pushed by dfaure into branch 'master'.

Add missing parent for child widget, which messed up tab order.

Yet another reason for explicit parents. Mixing explicit and implicit
leads to a wrong tab order (children with explicit parent first,
then reparented children).

M  +1    -1    src/texteditor/commonwidget/textfindreplacewidget.cpp

http://commits.kde.org/kpimtextedit/3d28f62956584b72528aea0e6416e49bb9d1d2f4

diff --git a/src/texteditor/commonwidget/textfindreplacewidget.cpp \
b/src/texteditor/commonwidget/textfindreplacewidget.cpp index 3e332fa..df1ae79 100644
--- a/src/texteditor/commonwidget/textfindreplacewidget.cpp
+++ b/src/texteditor/commonwidget/textfindreplacewidget.cpp
@@ -37,7 +37,7 @@ TextReplaceWidget::TextReplaceWidget(QWidget *parent)
     const int marg = lay->margin();
     lay->setContentsMargins(marg, 0, marg, 0);
 
-    mReplace = new QLineEdit;
+    mReplace = new QLineEdit(this);
     mReplace->setClearButtonEnabled(true);
     lay->addWidget(mReplace);
 


[prev in list] [next in list] [prev in thread] [next in thread]