[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [krita] plugins/extensions: Don't try to build g'mic if gcc is too old.
From:       Lukast dev <lukast.dev () gmail ! com>
Date:       2016-05-01 17:54:36
Message-ID: CAKdU0rNoRMVr_QoLJc=wgN7fyUeXoojGoe3zOM3dYmGY27YSqA () mail ! gmail ! com
[Download RAW message or body]

Note that compiling issues (compiler segfault) may happen with versions of
g++ 4.8.1 and 4.8.2. So maybe just specific versions of gcc should be
excluded?

2016-04-27 12:53 GMT+02:00 Boudewijn Rempt <boud@valdyas.org>:

> Git commit 20d8ec0f51661d0113294aac3a917f977d9dc64e by Boudewijn Rempt.
> Committed on 27/04/2016 at 10:53.
> Pushed by rempt into branch 'master'.
>
> Don't try to build g'mic if gcc is too old.
>
> M  +2    -0    plugins/extensions/CMakeLists.txt
>
> http://commits.kde.org/krita/20d8ec0f51661d0113294aac3a917f977d9dc64e
>
> diff --git a/plugins/extensions/CMakeLists.txt
> b/plugins/extensions/CMakeLists.txt
> index b6628d5..edde808 100644
> --- a/plugins/extensions/CMakeLists.txt
> +++ b/plugins/extensions/CMakeLists.txt
> @@ -18,5 +18,7 @@ add_subdirectory( layersplit )
>  # Allow to skip building GMIC plugin
>  option(WITH_GMIC "Build the G'Mic plugin" ON)
>  if(WITH_GMIC)
> +if (CMAKE_COMPILER_IS_GNUCC AND CMAKE_CXX_COMPILER_VERSION
> VERSION_GREATER 4.8.3)
>      add_subdirectory( gmic )
>  endif()
> +endif()
>
>

[Attachment #3 (text/html)]

<div dir="ltr">Note that compiling issues (compiler segfault) may happen with \
versions of g++ 4.8.1 and 4.8.2. So maybe just specific versions of gcc should be \
excluded?<br><div class="gmail_extra"><br><div class="gmail_quote">2016-04-27 12:53 \
GMT+02:00 Boudewijn Rempt <span dir="ltr">&lt;<a href="mailto:boud@valdyas.org" \
target="_blank">boud@valdyas.org</a>&gt;</span>:<br><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Git commit \
20d8ec0f51661d0113294aac3a917f977d9dc64e by Boudewijn Rempt.<br> Committed on \
27/04/2016 at 10:53.<br> Pushed by rempt into branch &#39;master&#39;.<br>
<br>
Don&#39;t try to build g&#39;mic if gcc is too old.<br>
<br>
M   +2      -0      plugins/extensions/CMakeLists.txt<br>
<br>
<a href="http://commits.kde.org/krita/20d8ec0f51661d0113294aac3a917f977d9dc64e" \
rel="noreferrer" target="_blank">http://commits.kde.org/krita/20d8ec0f51661d0113294aac3a917f977d9dc64e</a><br>
 <br>
diff --git a/plugins/extensions/CMakeLists.txt \
b/plugins/extensions/CMakeLists.txt<br> index b6628d5..edde808 100644<br>
--- a/plugins/extensions/CMakeLists.txt<br>
+++ b/plugins/extensions/CMakeLists.txt<br>
@@ -18,5 +18,7 @@ add_subdirectory( layersplit )<br>
  # Allow to skip building GMIC plugin<br>
  option(WITH_GMIC &quot;Build the G&#39;Mic plugin&quot; ON)<br>
  if(WITH_GMIC)<br>
+if (CMAKE_COMPILER_IS_GNUCC AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER \
4.8.3)<br>  add_subdirectory( gmic )<br>
  endif()<br>
+endif()<br>
<br>
</blockquote></div><br></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]