[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [spacebar] app/package/contents/ui: [app] Change the conversation property type to QtObject
From:       Martin Klapetek <mklapetek () kde ! org>
Date:       2016-03-16 0:18:36
Message-ID: E1afzAa-0005fC-1w () scm ! kde ! org
[Download RAW message or body]

Git commit b1125bc6d363f1bf4fcd66d48633125c2dc6b379 by Martin Klapetek.
Committed on 16/03/2016 at 00:18.
Pushed by mklapetek into branch 'master'.

[app] Change the conversation property type to QtObject

Because Conversation is now an uncreatable type and QML does not allow
to use that as a property type

See https://bugreports.qt.io/browse/QTBUG-36752

M  +4    -1    app/package/contents/ui/ConversationPage.qml

http://commits.kde.org/spacebar/b1125bc6d363f1bf4fcd66d48633125c2dc6b379

diff --git a/app/package/contents/ui/ConversationPage.qml b/app/package/con=
tents/ui/ConversationPage.qml
index ed9c7f4..1b0ecc9 100644
--- a/app/package/contents/ui/ConversationPage.qml
+++ b/app/package/contents/ui/ConversationPage.qml
@@ -30,7 +30,10 @@ import org.kde.telepathy 0.1
 MobileComponents.Page {
     anchors.fill: parent
 =

-    property Conversation conversation
+    // This is somewhat a hack, the type should be Conversation
+    // but QML does not allow for uncreatable types to be property
+    // types, so needs to be QtObject instead
+    property QtObject conversation
     property string pageName: "conversationPage"
 =

     Loader {
[prev in list] [next in list] [prev in thread] [next in thread]