[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    [kexi] src/plugins/reports: KexiDBReportData::setSorting: Check result of appending sort field
From:       Jaroslaw Staniek <staniek () kde ! org>
Date:       2016-02-29 23:12:13
Message-ID: E1aaWz7-0000sv-Lh () scm ! kde ! org
[Download RAW message or body]

Git commit 90c1b0ce021092bd1cb9d252fc705f859d232a2a by Jaroslaw Staniek.
Committed on 29/02/2016 at 23:07.
Pushed by staniek into branch 'master'.

KexiDBReportData::setSorting: Check result of appending sort field

CID #1353507

M  +7    -2    src/plugins/reports/kexidbreportdata.cpp

http://commits.kde.org/kexi/90c1b0ce021092bd1cb9d252fc705f859d232a2a

diff --git a/src/plugins/reports/kexidbreportdata.cpp b/src/plugins/reports/kexidbreportdata.cpp
index 4cdd2e9..dd97f72 100644
--- a/src/plugins/reports/kexidbreportdata.cpp
+++ b/src/plugins/reports/kexidbreportdata.cpp
@@ -72,11 +72,16 @@ void KexiDBReportData::setSorting(const QList<SortedField>& sorting)
             return;
         KDbOrderByColumnList order;
         for (int i = 0; i < sorting.count(); i++) {
-            order.appendField(d->copySchema, sorting[i].field, sorting[i].order == Qt::AscendingOrder);
+            if (!order.appendField(d->copySchema, sorting[i].field,
+                                   sorting[i].order == Qt::AscendingOrder))
+            {
+                qWarning() << "Cannot set sort field" << i << sorting[i].field;
+                return;
+            }
         }
         d->copySchema->setOrderByColumnList(order);
     } else {
-        qDebug() << "Unable to sort null schema";
+        qWarning() << "Unable to sort null schema";
     }
 }
 

[prev in list] [next in list] [prev in thread] [next in thread]