[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: [dolphin] /: Detect FileMetaData framework at CMake stage becasuse Dolphin needs it
From:       Christoph Feck <cfeck () kde ! org>
Date:       2016-02-17 0:30:58
Message-ID: 201602170130.58783.cfeck () kde ! org
[Download RAW message or body]

On Wednesday 10 February 2016 22:38:27 Frank Reininghaus wrote:
> Git commit 15b20cd077c6743bb5ec947f5f3e014a4a32b110 by Frank
> Reininghaus. Committed on 10/02/2016 at 21:36.
> Pushed by freininghaus into branch 'master'.
> 
> Detect FileMetaData framework at CMake stage becasuse Dolphin needs
> it
> 
> M  +1    -0    CMakeLists.txt
> 
> http://commits.kde.org/dolphin/15b20cd077c6743bb5ec947f5f3e014a4a32
> b110
> 
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 96e39d8..7f1adcb 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -66,6 +66,7 @@ find_package(KF5 ${KF5_MIN_VERSION} 
REQUIRED
> COMPONENTS WindowSystem
>      Notifications
>      Crash
> +    FileMetaData
>  )
>  find_package(KF5 ${KF5_MIN_VERSION} OPTIONAL_COMPONENTS
>      Activities

There is a find_package(KF5FileMetaData) instruction a few lines 
further, allowing optional compilation with either KF5FileMetaData or 
KFileMetaDataWidget from KDELibs4Support.

If KF5FileMetaData is now required, I suggest to remove that option 
logic.

-- 
Christoph Feck
KDE Quality Team
[prev in list] [next in list] [prev in thread] [next in thread]